RenderWidgetHostViewChildFrame is sometimes deleted without Destroy() being called? |
||
Issue descriptionGiven that the speculative fix for https://bugs.chromium.org/p/chromium/issues/detail?id=760074 appears to be working, it seems likely that the root cause of that bug was an unexpected deletion of a RenderWidgetHostViewChildFrame that had not had its Destroy() method called first. We should try and (i) verify this hypothesis, (ii) find out why this is happening, and (iii) stop it. I've set a broad spectrum of OS labels on this bug until we know more.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d55a0bcebb3feca2f4a1a6972d63df1c1169b45f commit d55a0bcebb3feca2f4a1a6972d63df1c1169b45f Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed Sep 06 17:23:18 2017 Add DumpWithoutCrashing to RenderWidgetHostViewChildFrame destructor. This is a temporary diagnostic measure to determine if, and why, RenderWidgetHostViewChildFrame is sometimes destructed without Destroy() being called. Bug: 762511 Change-Id: If6b77ab85b6aeb35e784943d7437b05d75fa0168 Reviewed-on: https://chromium-review.googlesource.com/652351 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#499998} [modify] https://crrev.com/d55a0bcebb3feca2f4a1a6972d63df1c1169b45f/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/d55a0bcebb3feca2f4a1a6972d63df1c1169b45f/content/browser/renderer_host/render_widget_host_view_child_frame.h
,
Sep 13 2017
The NextAction date has arrived: 2017-09-13
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7847291030856293d7f6596598ad551266d9a64 commit e7847291030856293d7f6596598ad551266d9a64 Author: James MacLean <wjmaclean@chromium.org> Date: Mon Oct 02 20:25:14 2017 Revert "Add DumpWithoutCrashing to RenderWidgetHostViewChildFrame destructor." This reverts commit d55a0bcebb3feca2f4a1a6972d63df1c1169b45f. Reason for revert: This was a diagnostic CL to test a hypothesis about a crash. However we never observed any calls to DumpWithoutCrashing, so it's time to remove it. Original change's description: > Add DumpWithoutCrashing to RenderWidgetHostViewChildFrame destructor. > > This is a temporary diagnostic measure to determine if, and why, > RenderWidgetHostViewChildFrame is sometimes destructed without > Destroy() being called. > > Bug: 762511 > Change-Id: If6b77ab85b6aeb35e784943d7437b05d75fa0168 > Reviewed-on: https://chromium-review.googlesource.com/652351 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499998} TBR=creis@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 762511 Change-Id: I936517ba47473fb8442b648fce3295b0a87b0293 Reviewed-on: https://chromium-review.googlesource.com/695821 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#505755} [modify] https://crrev.com/e7847291030856293d7f6596598ad551266d9a64/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/e7847291030856293d7f6596598ad551266d9a64/content/browser/renderer_host/render_widget_host_view_child_frame.h
,
Oct 3 2017
Closing this, as we found no actual occurrences to suggest this is actually happening. |
||
►
Sign in to add a comment |
||
Comment 1 by wjmaclean@chromium.org
, Sep 6 2017