New issue
Advanced search Search tips

Issue 762510 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 760320



Sign in to add a comment

Content_Unittests-Viz: OffscreenCanvasProviderImplTest

Project Member Reported by jonr...@chromium.org, Sep 6 2017

Issue description

OffscreenCanvasProviderImplTest has dependencies on:
  -  services/viz/public/interfaces/compositing/compositor_frame_sink.mojom.h
  -  viz::FrameSinkId
  -  viz::SurfaceInfo
  -  viz::ReturnResource
  -  viz::BeginFrameArgs
  -  viz::HostFrameSinkManager
  -  viz::LocalSurfaceId

Find out how the Viz process split impacts this test, and update.
 
The stub pattern makes this safe.

Look into extracting the stub pattern.
Cc: jonr...@chromium.org
Owner: kylec...@chromium.org
Status: Assigned (was: Untriaged)
We can reuse FakeCompositorFrameSinkClient here.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ef4552d83f60f260c584c81b93d215f5a4aba1

commit e0ef4552d83f60f260c584c81b93d215f5a4aba1
Author: kylechar <kylechar@chromium.org>
Date: Wed Oct 25 17:42:05 2017

Reuse MockCompositorFrameSinkClient.

Replace StubCompositorFrameSinkClient with MockCompositorFrameSinkClient
in OffscreenCanvasProviderImplTest.

Bug:  762510 
Change-Id: I065744402eb0960d904b91ec808a363ee2bed7ad
Reviewed-on: https://chromium-review.googlesource.com/733611
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511509}
[modify] https://crrev.com/e0ef4552d83f60f260c584c81b93d215f5a4aba1/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc

Status: Fixed (was: Started)

Comment 7 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630b49ff40baeeb42251ada350287857b8dfb401

commit 630b49ff40baeeb42251ada350287857b8dfb401
Author: kylechar <kylechar@chromium.org>
Date: Fri Nov 17 15:55:10 2017

Add tests to viz_content_browsertests on FYI trybot.

Some OOPIF problems have been fixed when running content_browsertests
with --enable-viz. Add passing tests back to FYI trybot to check for
flaky tests.

TBR: sky@chromium.org
Bug:  762510 
Change-Id: I1e284daff7f46e05a3c7ecc447d16510ebef50b1
Reviewed-on: https://chromium-review.googlesource.com/775975
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517408}
[modify] https://crrev.com/630b49ff40baeeb42251ada350287857b8dfb401/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Sign in to add a comment