New issue
Advanced search Search tips

Issue 762442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make the time out longer to wait for CQ try jobs dry run

Project Member Reported by leon....@intel.com, Sep 6 2017

Issue description

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F1336%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout shows such a time out case:
'
Timed out waiting for try jobs.
2017-09-05 22:09:21,422 - Timed out waiting for CQ; aborting.
'

And actually the CQ try jobs got a OK result later after the above time point. The win_chromium_rel_ng bot is the last one, and yes usually Windows bots are slower than other platforms.
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/526899 shows:
'
End	Tue Sep 5 22:26:36 2017
Elapsed	1 hrs, 4 mins, 51 secs
'

Currently the time out configuration is 'TIMEOUT_SECONDS = 180 * 60', if we can make it 20 minutes longer, the above case should be OK.
So, can we just extend it? Or there are some reasons to adhere to 3 hours?
From my experiences on dry running Chromium CLs, seems if win_chromium_rel_ng bot did some retries, it would be easy to take time longer than 3 hours, although I have no concrete statistics data about that.
 
Status: Available (was: Untriaged)
There's no particular reason to adhere to 3 hours in particular; waiting a little longer should be fine.

Comment 2 by leon....@intel.com, Sep 7 2017

Owner: leon....@intel.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e3ac7e63bd76f506a15965384a5bfca4c10e8d7

commit 1e3ac7e63bd76f506a15965384a5bfca4c10e8d7
Author: Han Leon <leon.han@intel.com>
Date: Thu Sep 07 22:20:15 2017

[Infra] Make the time out configuration longer to wait for CQ try jobs

This CL extends the time out configuration from 3 hours to 3.5 hours
because sometimes Windows try bots may take longer time than 3 hours to
get an OK result after several retries.

BUG= 762442 

Change-Id: I7c6f941bcbf80b7823099926493f7445bf795c67
Reviewed-on: https://chromium-review.googlesource.com/654443
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#500408}
[modify] https://crrev.com/1e3ac7e63bd76f506a15965384a5bfca4c10e8d7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Comment 4 by leon....@intel.com, Sep 7 2017

Status: Fixed (was: Started)

Sign in to add a comment