Focus highlight is not seen on checkbox after pressing tab key in Devtools
Reported by
nutan.ga...@etouch.net,
Sep 6 2017
|
||||||||||||||
Issue descriptionChrome version : 62.0.3202.9 af8baa4f5884a58cb31839507cce2a4a5577f6c6-refs/branch-heads/3202@{#36} OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6,10.12.3,10.12.5) What steps will reproduce the problem? 1. Launch chrome, navigate to NTP and open dev tools 2. Click on ‘Customise and control DevTools’ icon > Settings > Devices 3. Press single tab and press space bar/enter button and observe Actual: 1. Focus highlight is not seen on checkbox after pressing tab key 2. Checkbox do not check or uncheck after pressing space bar/enter key Expected: 1. Focus highlight should be seen on checkbox after pressing tab key 2. Checkbox should check or uncheck after pressing space bar/enter key This is an Non-Regression issue seen from M-45
,
Sep 6 2017
Untriaging it so that it gets addressed.
,
Sep 11 2017
I personally would REALLY like the focus highlight on checkboxes, yes.
,
Sep 11 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84aeb31e5505a4224f0f033cbfa9452bc259decf commit 84aeb31e5505a4224f0f033cbfa9452bc259decf Author: Joel Einbinder <einbinder@chromium.org> Date: Mon Oct 30 22:49:34 2017 DevTools: Show focus outline for checkboxes in devices screen Also stops propagation if the checkbox is clicked to prevent the default click handler from unchecking the box. Bug: 762441 Change-Id: I6a304221d1c9ae52d592645d430c61fa621741c2 Reviewed-on: https://chromium-review.googlesource.com/744340 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512656} [modify] https://crrev.com/84aeb31e5505a4224f0f033cbfa9452bc259decf/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js [modify] https://crrev.com/84aeb31e5505a4224f0f033cbfa9452bc259decf/third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css
,
Oct 30 2017
,
Oct 31 2017
Update : Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest Canary #64.0.3254.0 and issue is fixed. Kindly review an attached video. Thank you
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by nutan.ga...@etouch.net
, Sep 6 2017Summary: Focus highlight is not seen on checkbox after pressing tab key in Devtools (was: Focus highlight is not seen on checkbox after pressing tab key )