android_system_sdk needs a URL in README.chromium |
||||||
Issue descriptionhttps://chromium-review.googlesource.com/590988 added third_party/android_system_sdk to the tree. The directory (but not the actual JARs) have started shipping with M61 source tarballs, and the lack of a URL in README.chromium is causing tools/licenses.py to fail to scan the directory: licenses.LicenseError: couldn't find 'URL' line in README.chromium or licences.py SPECIAL_CASES Since it's not clear to me what URL it should point to, I'm filing a bug instead of a CL. Let me know if the directory should just be excluded from the source tarballs instead; in this case, I can send a CL updating the tarball publication script.
,
Sep 28
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 29
jbudorick@ As best as I can determine, the URL we download this from is from the internal Android build page, which we probably should not leak in upstream code. I'm not sure what the source tarballs are, so perhaps this should be excluded as suggested in the initial report. Or, is there some public URL I'm not aware of for the system sdk?
,
Oct 3
I sent out a CL: http://crrev/c/1260207
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b2fe1f8684b9dea14adeea5e0b8de0a24b7215f commit 3b2fe1f8684b9dea14adeea5e0b8de0a24b7215f Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Oct 04 19:40:44 2018 Android: link to a URL for the system SDK This adds a URL to README.chromium under system SDK. This is an internal URL, as the system SDK is only available internally anyway. Proper instructions for updating this dependency live at http://go/clank-webview/rolling-the-android-sdk. R=torne@chromium.org Bug: 762432 Test: N/A Change-Id: I390d28e172d728cdc03330dec3be69e0c9977214 Reviewed-on: https://chromium-review.googlesource.com/c/1260207 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596808} [modify] https://crrev.com/3b2fe1f8684b9dea14adeea5e0b8de0a24b7215f/third_party/android_system_sdk/README.chromium
,
Oct 4
I verified this locally with: $ tools/licenses.py scan # android_system_sdk is not in error output. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sgu...@chromium.org
, Sep 27 2017