New issue
Advanced search Search tips

Issue 762426 link

Starred by 1 user
Status: Fixed
Owner:
sprang@chromium.org
Closed: Sep 2017
Cc:
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M62: Ability to force software encoder fallback for screen sharing

Project Member Reported by sprang@chromium.org, Sep 6 2017 
Hardware encoders can have sever issues with presentation type screensharing therefore this CL allows forcing a fallback in such situations:

https://chromium-review.googlesource.com/c/chromium/src/+/647849

This is an important feature we would like to merge into M62.

See also b/62726302
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c1d5cb51de1a3bcfc99ba1e3fca8d39083fa40c

commit 1c1d5cb51de1a3bcfc99ba1e3fca8d39083fa40c
Author: Erik Språng <sprang@chromium.org>
Date: Sun Sep 10 22:45:46 2017

Add feature flag disabling hw codec for screensharing

TEST=Manual test on guado platform. Verified that sent bitstream
contains two temporal layers after switching to screenshare.

BUG=b:62726302,  chromium:762426 
TBR=sprang@chromium.org

(cherry picked from commit 1bc09becc1aeaf1c893e722da8e47ab69c04b781)

Change-Id: Ibcc96243ae244c66007e83667438f1d853042982
Reviewed-on: https://chromium-review.googlesource.com/647849
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Erik Språng <sprang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499468}
Reviewed-on: https://chromium-review.googlesource.com/654861
Cr-Commit-Position: refs/branch-heads/3202@{#111}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/1c1d5cb51de1a3bcfc99ba1e3fca8d39083fa40c/content/public/common/content_features.cc
[modify] https://crrev.com/1c1d5cb51de1a3bcfc99ba1e3fca8d39083fa40c/content/public/common/content_features.h
[modify] https://crrev.com/1c1d5cb51de1a3bcfc99ba1e3fca8d39083fa40c/content/renderer/media/gpu/rtc_video_encoder.cc

Comment 3 by sprang@chromium.org, Sep 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment