New issue
Advanced search Search tips

Issue 762408 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

On some platforms, the allowed API call jitter in AEC3 is too low, resulting in excessive resets

Project Member Reported by peah@chromium.org, Sep 6 2017

Issue description

On some platforms, the allowed API call jitter in AEC3 is too low, resulting in excessive resets. Since resets have a negative impact on the AEC performance, that is not desired.
 

Comment 1 by peah@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/cd8b079afb1859a7579cfc9a9fc8af3a2fef6673

commit cd8b079afb1859a7579cfc9a9fc8af3a2fef6673
Author: peah <peah@webrtc.org>
Date: Wed Aug 30 13:19:11 2017

Increased the allowed API call jitter in AEC3

This CL increases the amount of API call jitter that is allowed in AEC3
without causing resets of AEC3. This increase is now possible, as non-
causal alignments will be detected by the newly imposed delay bound.

BUG= webrtc:8175 

Review-Url: https://codereview.webrtc.org/3012553002
Cr-Commit-Position: refs/heads/master@{#19603}

[modify] https://crrev.com/cd8b079afb1859a7579cfc9a9fc8af3a2fef6673/webrtc/modules/audio_processing/aec3/aec3_common.h

Comment 2 by peah@chromium.org, Sep 6 2017

We would like to merge this into M62. Since the CL landed before the WebRTC cut to M62, but ended up not being included in that cut, I had no corresponding Chromium issue and could not follow the normal way of requesting a merge.

I therefore in #1 pasted the information about the CL into comment #1 above.

Comment 3 by peah@chromium.org, Sep 6 2017

We would like to merge this into M62. Since the CL landed before the WebRTC cut to M62, but ended up not being included in that cut, I had no corresponding Chromium issue and could not follow the normal way of requesting a merge.

I therefore in #1 pasted the information about the CL into comment #1 above.

Comment 4 by peah@chromium.org, Sep 6 2017

Labels: Merge-Request-62
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0116041b1c9671288c24c8bd6c895992dc7563eb

commit 0116041b1c9671288c24c8bd6c895992dc7563eb
Author: peah <peah@webrtc.org>
Date: Thu Sep 07 17:22:27 2017

Merge of increased the allowed API call jitter in AEC3

This CL increases the amount of API call jitter that is allowed in AEC3
without causing resets of AEC3. This increase is now possible, as non-
causal alignments will be detected by the newly imposed delay bound.

NOTRY=true
NOPRESUBMIT=true
TBR=ivoc@webrtc.org
BUG= webrtc:8175 ,  chromium:762408 

Review-Url: https://codereview.webrtc.org/3012553002
Cr-Original-Commit-Position: refs/heads/master@{#19603}
(cherry picked from commit cd8b079afb1859a7579cfc9a9fc8af3a2fef6673)
Review-Url: https://codereview.webrtc.org/3013473002
Cr-Commit-Position: refs/branch-heads/62@{#2}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}

[modify] https://crrev.com/0116041b1c9671288c24c8bd6c895992dc7563eb/webrtc/modules/audio_processing/aec3/aec3_common.h

Project Member

Comment 7 by sheriffbot@chromium.org, Sep 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 15 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by peah@chromium.org, Sep 15 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-62
Status: Fixed (was: Assigned)

Sign in to add a comment