The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6abebbbae1e406ab0d3a4bdb9a21f4d4e16877b7

commit 6abebbbae1e406ab0d3a4bdb9a21f4d4e16877b7
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Sep 15 02:50:29 2017

[Desktop PWAs] Make window titles show on ChromeOS.

This CL makes window titles show for browser 'app' windows on ChromeOS.

Bug: 762401
Change-Id: I32a5934d5d09b453c33cceee7fabcec39cfcd909
Reviewed-on: https://chromium-review.googlesource.com/651675
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502143}
[modify] https://crrev.com/6abebbbae1e406ab0d3a4bdb9a21f4d4e16877b7/chrome/browser/ui/browser.cc
[modify] https://crrev.com/6abebbbae1e406ab0d3a4bdb9a21f4d4e16877b7/chrome/browser/ui/browser.h
[modify] https://crrev.com/6abebbbae1e406ab0d3a4bdb9a21f4d4e16877b7/chrome/browser/ui/views/frame/browser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30416404229d75a5adf904345461da449ebed36

commit e30416404229d75a5adf904345461da449ebed36
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Oct 04 02:53:58 2017

[desktop-pwas] Show app icon in title bar on CrOS.

This CL makes the app icon always show on CrOS for desktop PWAs. We use
the extension app icon that is bundled into the bookmark app. This will
also cause other platforms to show the app icon instead of the window
icon when using DesktopPWAWindowing.

Bug: 762401
Change-Id: I8b82d98a744dc67b39132c3bea2510e41460ca50
Reviewed-on: https://chromium-review.googlesource.com/676686
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506286}
[modify] https://crrev.com/e30416404229d75a5adf904345461da449ebed36/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/e30416404229d75a5adf904345461da449ebed36/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[modify] https://crrev.com/e30416404229d75a5adf904345461da449ebed36/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e30416404229d75a5adf904345461da449ebed36/chrome/browser/ui/views/frame/browser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ffdd673e85cfa59138c077cc35a29755851415a

commit 4ffdd673e85cfa59138c077cc35a29755851415a
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Oct 13 04:43:23 2017

Add rgb and rgba color parsing to extensions image_utils.

This CL is a precursor to Change 680677 which needs to store a color
with transparency. To do this, we plan to store the color as an rgba
string, which is converted back by the function added in this patch.

The RGB parsing here does not handle percentages, for simplicity.

Bug: 762401
Change-Id: I1304f0444be4c80536a26bbb97dd653503d1b9c2
Reviewed-on: https://chromium-review.googlesource.com/711775
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508592}
[modify] https://crrev.com/4ffdd673e85cfa59138c077cc35a29755851415a/extensions/common/image_util.cc
[modify] https://crrev.com/4ffdd673e85cfa59138c077cc35a29755851415a/extensions/common/image_util.h
[modify] https://crrev.com/4ffdd673e85cfa59138c077cc35a29755851415a/extensions/common/image_util_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cec8c4f96726580deac894210647e9d2c9118694

commit cec8c4f96726580deac894210647e9d2c9118694
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Oct 16 01:38:43 2017

[desktop-pwas] Show and sync theme color for bookmark apps on CrOS.

This CL makes bookmark apps display their title bar in the theme color
specified by the manifest. It also syncs this field across devices with
all other bookmark app information.

This adds a theme_color key to the extension manifest and app sync
specifics which represents the theme color in the extension and sync
systems respectively.

Bug: 762401
Change-Id: If13d58558122ea89efa75dba392b187956c0ff69
Reviewed-on: https://chromium-review.googlesource.com/680677
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508970}
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/ash/frame/default_header_painter.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_browsertest.h
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_sync_data.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_sync_data.h
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_sync_data_unittest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/sync/test/integration/sync_app_helper.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/BUILD.gn
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/api/_manifest_features.json
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/chrome_manifest_handlers.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/manifest_handlers/app_icon_color_info.cc
[add] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/manifest_handlers/app_theme_color_info.cc
[add] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/manifest_handlers/app_theme_color_info.h
[add] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/extensions/manifest_handlers/app_theme_color_manifest_unittest.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/web_application_info.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/common/web_application_info.h
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/test/BUILD.gn
[add] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/test/data/extensions/manifest_tests/theme_color.json
[add] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/chrome/test/data/extensions/manifest_tests/theme_color_wrong_type.json
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/components/sync/protocol/app_specifics.proto
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/extensions/common/manifest_constants.cc
[modify] https://crrev.com/cec8c4f96726580deac894210647e9d2c9118694/extensions/common/manifest_constants.h

Mocks exist at go/desktop-pwa-mocks.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56addd08d5dd828b5092a903f0683ad8f0944060

commit 56addd08d5dd828b5092a903f0683ad8f0944060
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Oct 30 03:22:59 2017

[desktop-pwas] Add an app menu button to hosted app windows on CrOS.

This CL adds a HostedAppButtonContainer which currently houses a menu
button which launches the app menu. This menu will later be tailored to
hosted apps and the container will also show content setting indicators.

Bug: 762401
Change-Id: I2cde2d0208e7afefd0508ffdf1ab8261f82c1f17
Reviewed-on: https://chromium-review.googlesource.com/701857
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512436}
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/ash/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[add] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[add] https://crrev.com/56addd08d5dd828b5092a903f0683ad8f0944060/chrome/browser/ui/views/frame/hosted_app_button_container.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4380e3b00fb98ad100d264c3e3799744f0253a54

commit 4380e3b00fb98ad100d264c3e3799744f0253a54
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Nov 01 03:01:50 2017

[desktop-pwas] Add a custom menu model for the Hosted App Menu Button.

This CL adds a custom menu model for hosted app which has only the items
that should be shown for a hosted app. It also adds 3 new commands which
are currently disabled and will be implemented in a future CL.

Bug: 762401
Change-Id: I7e53eb3d11042f267567e3773784c8594d7c7bee
TBR: erg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/721226
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513058}
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/app/chromium_strings.grd
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/app/generated_resources.grd
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/profiles/profile_window_browsertest.cc
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[add] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/extensions/hosted_app_menu_model.cc
[add] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/extensions/hosted_app_menu_model.h
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/toolbar/app_menu_model.h
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/toolbar/app_menu_model_unittest.cc
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/4380e3b00fb98ad100d264c3e3799744f0253a54/chrome/browser/ui/views/toolbar/app_menu_button.cc

Which mock is the window frame design that's being implemented?

Phase 1 UI, but the mocks are for Windows. ChromeOS redlines are forthcoming.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/881c1b3d573be9408bce097ca4bd919f87fbe5a3

commit 881c1b3d573be9408bce097ca4bd919f87fbe5a3
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Nov 07 01:54:09 2017

[desktop-pwas] Make app menu button change color when inactive.

This CL makes the app menu button in hosted app windows fade lighter
when the window isn't focused, so that the icon color is the same as
the minimize/maximize/close buttons.

Bug: 762401
Change-Id: I2ffa883fc6907ebeb91c59c1d631965bf1bf4577
Reviewed-on: https://chromium-review.googlesource.com/754766
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514348}
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/ash/ash_constants.cc
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/ash/ash_constants.h
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/ash/frame/default_header_painter.cc
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/ash/frame/default_header_painter.h
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/881c1b3d573be9408bce097ca4bd919f87fbe5a3/chrome/browser/ui/views/frame/hosted_app_button_container.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbac2beb9d5800b882314387d7fd449f14d4a2c

commit 0dbac2beb9d5800b882314387d7fd449f14d4a2c
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Nov 14 07:12:10 2017

[desktop-pwas] Implement HostedAppMenuModel commands.

This CL adds implementations for the 3 hosted app menu commands:
- Open Site Settings
- Copy URL
- Open in Chrome

Bug: 762401
Change-Id: Ia9ac52999dfcb2ab1ad2408862843e417bb988fd
Reviewed-on: https://chromium-review.googlesource.com/746047
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516220}
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/chrome_pages.h
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/0dbac2beb9d5800b882314387d7fd449f14d4a2c/chrome/browser/ui/page_info/page_info.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/662865528550cee1ef5e178adec5a558d0705056

commit 662865528550cee1ef5e178adec5a558d0705056
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Nov 17 03:02:13 2017

Rename ash::HeaderPainter to FrameHeader.

This CL renames the HeaderPainter because it does much more than
painting which has become confusing. This is a precursor CL to
https://chromium-review.googlesource.com/c/chromium/src/+/768601.

Bug: 762401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: Ie41fa68c8b4559e258eac6eee957cc059794bd96
Reviewed-on: https://chromium-review.googlesource.com/774058
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517265}
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/BUILD.gn
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/default_frame_header.cc
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/default_frame_header.h
[add] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/default_frame_header_unittest.cc
[delete] https://crrev.com/177b8e6b81c434a2c5fc55f3286348d892e91500/ash/frame/default_header_painter_unittest.cc
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/frame_header.h
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/frame_header_util.cc
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/frame_header_util.h
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/header_view.cc
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/frame/header_view.h
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_frame_header_ash.cc
[rename] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_frame_header_ash.h
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/662865528550cee1ef5e178adec5a558d0705056/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38c60c130cab61106734501af4844bae5176cee4

commit 38c60c130cab61106734501af4844bae5176cee4
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Nov 20 08:23:39 2017

[desktop-pwas] Render 'App name by example.com' string in window title.

This CL adds an extra string to the Desktop PWA window title that
denotes which app the window belongs to and the domain of the start URL.
The window title is painted such that the page title will elide first,
followed by the app name then the domain. Further work is required to
maintain this property for all languages.

Bug: 762401
Change-Id: Ibcc697b02fa643df9c2618ca0ef0249c6f887b64
Reviewed-on: https://chromium-review.googlesource.com/768601
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517782}
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/default_frame_header.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/default_frame_header.h
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/default_frame_header_unittest.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/frame_header_util.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/frame_header_util.h
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/frame/header_view.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/app/generated_resources.grd
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/browser_frame_header_ash.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[add] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[add] https://crrev.com/38c60c130cab61106734501af4844bae5176cee4/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8

commit 64ae7852b4e5ee31f08001d3ef293cf159a4bfd8
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Nov 28 04:15:50 2017

[desktop-pwas] Add content setting indicators to Hosted App frame.

This CL adds ContentSettingImageViews to the HostedAppButtonContainer by:
- Factoring out a Delegate for ContentSettingImageView which the
  HostedAppButtonContainer and LocationBarView implement
- Adding an icon color override to ContentSettingImageView
- Moving the HostedAppButtonContainer to BrowserNonClientView instead of
  BrowserNonClientViewAsh so that BrowserView can access it
  (which also prepares its addition to OpaqueBrowserFrameView).

This all allows the content setting indicators to be embedded in the
hosted app frame, get notified of content setting changes, and respond
to active/inactive states.

Bug: 762401
Change-Id: I3f65f022201740c8e5a066937d32c189f283a048
Reviewed-on: https://chromium-review.googlesource.com/756634
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519562}
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/ash/frame/default_frame_header.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/ash/frame/default_frame_header.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/64ae7852b4e5ee31f08001d3ef293cf159a4bfd8/chrome/browser/ui/views/location_bar/location_bar_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/239851507bec526a2c365b4d68b778e98509ffcb

commit 239851507bec526a2c365b4d68b778e98509ffcb
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Nov 28 10:01:10 2017

Revert "[desktop-pwas] Add content setting indicators to Hosted App frame."

This reverts commit 64ae7852b4e5ee31f08001d3ef293cf159a4bfd8.

Reason for revert: suspected to cause bunch of MSAN error

https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests

Original change's description:
> [desktop-pwas] Add content setting indicators to Hosted App frame.
>
> This CL adds ContentSettingImageViews to the HostedAppButtonContainer by:
> - Factoring out a Delegate for ContentSettingImageView which the
>   HostedAppButtonContainer and LocationBarView implement
> - Adding an icon color override to ContentSettingImageView
> - Moving the HostedAppButtonContainer to BrowserNonClientView instead of
>   BrowserNonClientViewAsh so that BrowserView can access it
>   (which also prepares its addition to OpaqueBrowserFrameView).
>
> This all allows the content setting indicators to be embedded in the
> hosted app frame, get notified of content setting changes, and respond
> to active/inactive states.
>
> Bug: 762401
> Change-Id: I3f65f022201740c8e5a066937d32c189f283a048
> Reviewed-on: https://chromium-review.googlesource.com/756634
> Commit-Queue: calamity <calamity@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519562}

TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org

Change-Id: Id42cff75e0792818065a9a3fc9816011b7caa367
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762401
Reviewed-on: https://chromium-review.googlesource.com/792583
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519631}
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/ash/frame/default_frame_header.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/ash/frame/default_frame_header.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/239851507bec526a2c365b4d68b778e98509ffcb/chrome/browser/ui/views/location_bar/location_bar_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/575f58ecee8aa6f1836d85f1dd1310ef0a311c20

commit 575f58ecee8aa6f1836d85f1dd1310ef0a311c20
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Nov 28 10:21:55 2017

Revert "Revert "[desktop-pwas] Add content setting indicators to Hosted App frame.""

This reverts commit 239851507bec526a2c365b4d68b778e98509ffcb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[desktop-pwas] Add content setting indicators to Hosted App frame."
> 
> This reverts commit 64ae7852b4e5ee31f08001d3ef293cf159a4bfd8.
> 
> Reason for revert: suspected to cause bunch of MSAN error
> 
> https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests
> 
> Original change's description:
> > [desktop-pwas] Add content setting indicators to Hosted App frame.
> >
> > This CL adds ContentSettingImageViews to the HostedAppButtonContainer by:
> > - Factoring out a Delegate for ContentSettingImageView which the
> >   HostedAppButtonContainer and LocationBarView implement
> > - Adding an icon color override to ContentSettingImageView
> > - Moving the HostedAppButtonContainer to BrowserNonClientView instead of
> >   BrowserNonClientViewAsh so that BrowserView can access it
> >   (which also prepares its addition to OpaqueBrowserFrameView).
> >
> > This all allows the content setting indicators to be embedded in the
> > hosted app frame, get notified of content setting changes, and respond
> > to active/inactive states.
> >
> > Bug: 762401
> > Change-Id: I3f65f022201740c8e5a066937d32c189f283a048
> > Reviewed-on: https://chromium-review.googlesource.com/756634
> > Commit-Queue: calamity <calamity@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#519562}
> 
> TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org
> 
> Change-Id: Id42cff75e0792818065a9a3fc9816011b7caa367
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 762401
> Reviewed-on: https://chromium-review.googlesource.com/792583
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519631}

TBR=jamescook@chromium.org,kinuko@chromium.org,tapted@chromium.org,calamity@chromium.org,hbos@chromium.org

Change-Id: I90d290ed7c70afb695c2f8b2b11cf1dbb9265db7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762401
Reviewed-on: https://chromium-review.googlesource.com/792584
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519637}
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/ash/frame/default_frame_header.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/ash/frame/default_frame_header.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/575f58ecee8aa6f1836d85f1dd1310ef0a311c20/chrome/browser/ui/views/location_bar/location_bar_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047

commit dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Nov 28 10:45:42 2017

Revert (2nd time) "[desktop-pwas] Add content setting indicators to Hosted App frame."

This reverts commit 64ae7852b4e5ee31f08001d3ef293cf159a4bfd8.

Reason for revert: suspected to cause bunch of MSAN errors
https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests

Original change's description:
> [desktop-pwas] Add content setting indicators to Hosted App frame.
> 
> This CL adds ContentSettingImageViews to the HostedAppButtonContainer by:
> - Factoring out a Delegate for ContentSettingImageView which the
>   HostedAppButtonContainer and LocationBarView implement
> - Adding an icon color override to ContentSettingImageView
> - Moving the HostedAppButtonContainer to BrowserNonClientView instead of
>   BrowserNonClientViewAsh so that BrowserView can access it
>   (which also prepares its addition to OpaqueBrowserFrameView).
> 
> This all allows the content setting indicators to be embedded in the
> hosted app frame, get notified of content setting changes, and respond
> to active/inactive states.
> 
> Bug: 762401
> Change-Id: I3f65f022201740c8e5a066937d32c189f283a048
> Reviewed-on: https://chromium-review.googlesource.com/756634
> Commit-Queue: calamity <calamity@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519562}

TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org

Change-Id: I3a9511ecb27f2e388e4a8dab3a46cdf37cbc3647
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762401
Reviewed-on: https://chromium-review.googlesource.com/792585
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519643}
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/ash/frame/default_frame_header.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/ash/frame/default_frame_header.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/dbf2063a393a7d8eab1b8ea84cf3ee2af4ee7047/chrome/browser/ui/views/location_bar/location_bar_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a92c0110e253df8d358b0d47a5a098595116566

commit 2a92c0110e253df8d358b0d47a5a098595116566
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Nov 29 02:11:16 2017

Reland "[desktop-pwas] Add content setting indicators to Hosted App frame."

Relanded with an uninitialized field fixed.

This CL adds ContentSettingImageViews to the HostedAppButtonContainer by:
- Factoring out a Delegate for ContentSettingImageView which the
  HostedAppButtonContainer and LocationBarView implement
- Adding an icon color override to ContentSettingImageView

This all allows the content setting indicators to be embedded in the
hosted app frame, get notified of content setting changes, and respond
to active/inactive states.

TBR=tapted@chromium.org, jamescook@chromium.org

Bug: 762401
Change-Id: I28e1f708f25dbb9722384fb23e9ca2825b5b4e10
Reviewed-on: https://chromium-review.googlesource.com/795271
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519962}
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/ash/frame/default_frame_header.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/ash/frame/default_frame_header.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566/chrome/browser/ui/views/location_bar/location_bar_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86b5271acb0ded5624786ace5095f48770a3fd2b

commit 86b5271acb0ded5624786ace5095f48770a3fd2b
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Dec 04 01:58:33 2017

[desktop-pwas] Add 'App info' button to hosted app menu.

This CL adds a button that opens the app info dialog to the hosted app
menu.

Bug: 762401
Change-Id: I23ec79904932bdb35dce80d642a6d3582e29ec5e
Reviewed-on: https://chromium-review.googlesource.com/788630
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521250}
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/extensions/hosted_app_menu_model.cc
[modify] https://crrev.com/86b5271acb0ded5624786ace5095f48770a3fd2b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d10877ec194bfab910d6033527a6c08412ee6f1

commit 3d10877ec194bfab910d6033527a6c08412ee6f1
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jan 30 04:13:45 2018

[desktop-pwas] Remove title text from desktop PWA window.

This CL removes the title bar text from the desktop PWA window.

Bug: 762401
Change-Id: Ia6dd5feb6075958a5648eecfb7cf17c0aaa25e77
Reviewed-on: https://chromium-review.googlesource.com/882628
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532746}
[modify] https://crrev.com/3d10877ec194bfab910d6033527a6c08412ee6f1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3d10877ec194bfab910d6033527a6c08412ee6f1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/3d10877ec194bfab910d6033527a6c08412ee6f1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/3d10877ec194bfab910d6033527a6c08412ee6f1/chrome/browser/ui/views/frame/browser_view.cc
[delete] https://crrev.com/c32b18d4361a2a2aa27ce70fbc78c771930c3caf/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.cc
[delete] https://crrev.com/c32b18d4361a2a2aa27ce70fbc78c771930c3caf/chrome/browser/ui/views/frame/hosted_app_frame_header_ash.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851605b62f2be34bee8d8242f850cce65184a4a3

commit 851605b62f2be34bee8d8242f850cce65184a4a3
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Feb 09 05:24:04 2018

Move browser_action_test_util.h into chrome/browser/ui/extensions.

This CL moves a header file into the same directory structure as its
actual implementations. This is a precursor to
https://chromium-review.googlesource.com/c/chromium/src/+/897383 which
breaks dependencies without this change.

Bug: 762401
Tbr: benwells@chromium.org
Change-Id: I944c96bfb4146ba77bf8d96f5fca614da68cb8c3
Reviewed-on: https://chromium-review.googlesource.com/906143
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535651}
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/extension_incognito_apitest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/extension_keybinding_apitest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm
[rename] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/extensions/browser_action_test_util.h
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.h
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
[modify] https://crrev.com/851605b62f2be34bee8d8242f850cce65184a4a3/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1

commit a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Feb 21 06:24:31 2018

[desktop-pwas] Use PreferredSizeChanged in BrowserActionsContainer.

This CL makes BrowserActionsContainer use PreferredSizeChanged to notify
its parent of size changes rather than just calling parent()->Layout()
directly. This is in preparation of adding a BrowserActionsContainer to
the HostedAppContainer
(https://chromium-review.googlesource.com/c/chromium/src/+/897383).

Bug: 762401
Change-Id: I4e1b0873ced13629d6ad1b602324d424ff30eef8
Reviewed-on: https://chromium-review.googlesource.com/910171
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538038}
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/ui/views/test/test_views.cc
[modify] https://crrev.com/a8d452d1df37ceb4916c0340c5ee92b87cfaa2c1/ui/views/test/test_views.h

Screenshot of the extensions experience in a Hosted App window.

Deleted: LZ37nSuCeJB.png 522 KB

	LZ37nSuCeJB.png 522 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e41336bdbc9e005faae85b6e60b7bc389ba9118

commit 3e41336bdbc9e005faae85b6e60b7bc389ba9118
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Feb 26 05:40:43 2018

[desktop-pwas] Add extensions to Hosted App window frame and menu.

This CL adds extension actions to the Hosted App window frame and menu
by:
- decoupling the BrowserActionsContainer from ToolbarView via a Delegate
- adding a BrowserActionsContainer to the HostedAppButtonContainer with
  a custom ToolbarActionsBar which only displays only the popped out action

Bug: 762401
Change-Id: I24c607d3111bc48e75e26c880cbd91d59d69b7e6
Reviewed-on: https://chromium-review.googlesource.com/897383
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539074}
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/extensions/hosted_app_menu_model.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/toolbar/toolbar_actions_bar.h
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/browser_view.h
[add] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/browser_view_button_provider.h
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/browser_actions_container.h
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/3e41336bdbc9e005faae85b6e60b7bc389ba9118/chrome/browser/ui/views/toolbar/toolbar_view.h