New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762395 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Switch to CommitPendingWrite with callback in policy code

Project Member Reported by pmarko@chromium.org, Sep 6 2017

Issue description

PrefService::CommitPendingWrite fires off an asynchronous write on the file thread.

There's now also CommitPendingWrite(base::OnceClosure done_callback) which will call the |done_callback| when done[1].

Go through the uses of CommitPendingWrite and switch to the version with the callback where it makes sense. 

[1] https://cs.chromium.org/chromium/src/components/prefs/pref_service.h?l=183&gs=cpp%253Aclass-PrefService%253A%253ACommitPendingWrite(base%253A%253AOnceCallback%253Cvoid%2B(void)%253E)%2540chromium%252F..%252F..%252Fcomponents%252Fprefs%252Fpref_service.h%257Cdecl&gsn=CommitPendingWrite&ct=xref_usages
 

Comment 1 by emaxx@chromium.org, Sep 11 2017

Cc: emaxx@chromium.org
Labels: Enterprise-Triaged
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: olsen@chromium.org
Owner: acostinas@chromium.org
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment