New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762381 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AppCacheNetworkServiceBrowserTest.VerifyRedirectedSubresourceAppCacheLoad in content_browsertests is flaky on many bots

Project Member Reported by tyoshino@chromium.org, Sep 6 2017

Issue description

Owner: michaeln@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b16420186ceb0a5050fd49eac8ddd6c12e12533

commit 9b16420186ceb0a5050fd49eac8ddd6c12e12533
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Thu Sep 07 02:12:14 2017

Disable a flaky test: AppCacheNetworkServiceBrowserTest.VerifyRedirectedSubresourceAppCacheLoad in content_browsertests

Tbr: michaeln@chromium.org
Bug:  762381 
Change-Id: Ia0e35991e41a5e9da532052ddd7c3b0775d950ab
Reviewed-on: https://chromium-review.googlesource.com/651613
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500187}
[modify] https://crrev.com/9b16420186ceb0a5050fd49eac8ddd6c12e12533/content/browser/appcache/appcache_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3ef0164c99594bba1622bad79b8fa3d004616a6

commit c3ef0164c99594bba1622bad79b8fa3d004616a6
Author: Michael Nordman <michaeln@google.com>
Date: Fri Sep 08 20:37:55 2017

[AppCache] Delete flaky VerifyRedirectedSubresourceAppCacheLoad browser test.

Instead, slightly modify an existing layout test (offline-access.html) to provide test coverage.

Also note we get greater test coverage this way. The deleted browser test only ran with
kNetworkService enabled, while the layout test runs with that enabled and disabled.

Bug:  762381 
Change-Id: I1ed7636dd4223fdffa0555d3b64323b353437139
Reviewed-on: https://chromium-review.googlesource.com/656298
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500648}
[modify] https://crrev.com/c3ef0164c99594bba1622bad79b8fa3d004616a6/content/browser/appcache/appcache_browsertest.cc
[delete] https://crrev.com/65d1d4f91b35d7d70bae6a4f2f1e2d1f908a8d97/content/test/data/appcache/simple_page_redirected_resource_manifest.html
[modify] https://crrev.com/c3ef0164c99594bba1622bad79b8fa3d004616a6/third_party/WebKit/LayoutTests/http/tests/appcache/offline-access.html
[modify] https://crrev.com/c3ef0164c99594bba1622bad79b8fa3d004616a6/third_party/WebKit/LayoutTests/http/tests/appcache/resources/offline-access.js
[modify] https://crrev.com/c3ef0164c99594bba1622bad79b8fa3d004616a6/third_party/WebKit/LayoutTests/http/tests/appcache/resources/offline-access.manifest

Status: Fixed (was: Assigned)

Sign in to add a comment