New issue
Advanced search Search tips

Issue 762380 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
eroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Enable unittests for AIA on Fuchsia when they are implemented in CertVerifyProcBuiltin

Project Member Reported by sergeyu@google.com, Sep 6 2017 
CertVerifyProcBuiltin currently doesn't support all features that are supported on other platforms, so some tests had to be disabled, see
https://chromium-review.googlesource.com/c/chromium/src/+/651606

re-enable these tests once the missing features are implemented
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884169a08ef299ce74b811f033605e4f49be51dc

commit 884169a08ef299ce74b811f033605e4f49be51dc
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 06 18:58:02 2017

Enable HTTPS tests on Fuchsia

Enabled HTTPS* tests on Fuchsia, since they should pass now. Updated
unittests for OCSP, AIA and CRL set, since these features are not
implemented in CertVerifyProcBuiltin.

Bug:  731302 ,  762380 
Change-Id: I5e4d3affe9783c502330d8784eb866a78ddd755e
Reviewed-on: https://chromium-review.googlesource.com/651606
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500025}
[modify] https://crrev.com/884169a08ef299ce74b811f033605e4f49be51dc/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/884169a08ef299ce74b811f033605e4f49be51dc/testing/buildbot/filters/fuchsia.net_unittests.filter

Comment 2 by eroman@chromium.org, Sep 6 2017

Components: Internals>Network>Certificate
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8d9d2008026c187174c23b0f77bc169f444e3c

commit 5f8d9d2008026c187174c23b0f77bc169f444e3c
Author: Eric Roman <eroman@chromium.org>
Date: Tue Oct 17 02:32:52 2017

Implement EVRootCAMetadata for Fuschia.

Bug:  762380 ,  649017 
Change-Id: Ice9f4c558974d39a44cb67e02f2da82ff4af7fa5
Reviewed-on: https://chromium-review.googlesource.com/721266
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509224}
[modify] https://crrev.com/5f8d9d2008026c187174c23b0f77bc169f444e3c/net/cert/ev_root_ca_metadata.cc
[modify] https://crrev.com/5f8d9d2008026c187174c23b0f77bc169f444e3c/net/cert/ev_root_ca_metadata.h
[modify] https://crrev.com/5f8d9d2008026c187174c23b0f77bc169f444e3c/net/url_request/url_request_unittest.cc

Comment 5 by eroman@chromium.org, Oct 19 2017

Summary: Enable unittests for AIA on Fuchsia when they are implemented in CertVerifyProcBuiltin (was: Enable unittests for OCSP, AIA and CRL set on Fuchsia when they are implemented in CertVerifyProcBuiltin)
All the tests are enabled except those requiring AIA.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25892702325fd4534617ce18a657d16cb4ba627

commit b25892702325fd4534617ce18a657d16cb4ba627
Author: Matt Mueller <mattm@chromium.org>
Date: Sat Jan 27 16:41:26 2018

net::CertVerifyProcBuiltin: do AIA fetching (if requested by VERIFY_CERT_IO_ENABLED)

Also call SetGlobalCertNetFetcher on OS_FUCHSIA (where CertVerifyProcBuiltin is the default).

Bug:  649017 , 762380 
Change-Id: I39ee5de34dd96914189f323ecbaffabfc645b642
Reviewed-on: https://chromium-review.googlesource.com/884841
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532227}
[modify] https://crrev.com/b25892702325fd4534617ce18a657d16cb4ba627/chrome/browser/io_thread.cc
[modify] https://crrev.com/b25892702325fd4534617ce18a657d16cb4ba627/net/cert/cert_verify_proc_builtin.cc
[modify] https://crrev.com/b25892702325fd4534617ce18a657d16cb4ba627/net/url_request/url_request_unittest.cc

Comment 7 by mattm@chromium.org, Jan 29 2018

Status: Fixed (was: Available)
►

Sign in to add a comment