Re-add something to the CQ for angle to get CrOS coverage |
|||||
Issue descriptionIn bug 743212 , I removed the "Linux ChromiumOS Ozone Builder" from chromium.chromiumos, and "Linux ChromiumOS Builder" from chromium.gpu.fyi, and in bug 760962 I removed the linux_chromium_chromeos_ozone_rel_ng trybot. I think in the confusion (?) of those CLs we might've lost some coverage for the ANGLE CQ, see https://bugs.chromium.org/p/chromium/issues/detail?id=743212#c20 , https://bugs.chromium.org/p/chromium/issues/detail?id=743212#c22 , and https://chromium-review.googlesource.com/c/angle/angle/+/648654#message-5162e445be85982591154b4832d8ec0e30494208 (and following). I think this means that we want the ANGLE CQ to have linux_chromium_chromeos_rel_ng in it, but to run the angle_end2end_tests. However, that test is not currently run on that bot. I'm not sure if the request is to add it to the bot, or to set up another new bot with that GN config but a different list of tests? (AFAIK, we can't just run the same bot but with a different set of tests). Per the Gerrit CL comment from kbr@, I'm going to assign this to fjhenigman to clarify what we want to do. Others can chime in as appropriate :).
,
Sep 6 2017
Taking this from Frank as the ANGLE CQ is broken. Somehow, the reference to chromium.gpu.fyi's "Linux ChromiumOS Builder" in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py?type=cs&q=linux_angle_chromeos_rel_ng&sq=package:chromium&l=205 went unnoticed when removing the builder this trybot refers to.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/8cf8f7b08cfa0f2eee18d015de27ac465079593b commit 8cf8f7b08cfa0f2eee18d015de27ac465079593b Author: Kenneth Russell <kbr@chromium.org> Date: Wed Sep 06 17:02:50 2017 Remove linux_angle_chromeos_rel_ng from default bots. This trybot was broken during the removal of the Linux ChromiumOS Builder from chromium.gpu.fyi and is blocking all ANGLE CQ jobs. BUG= 762377 TBR=dpranke@chromium.org, jmadill@chromium.org NOTRY=true Change-Id: Ibc3ccf3af842ee8b040014732d179573f286afad Reviewed-on: https://chromium-review.googlesource.com/653244 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/8cf8f7b08cfa0f2eee18d015de27ac465079593b/infra/config/cq.cfg
,
Sep 6 2017
,
Sep 6 2017
ANGLE's CQ should be working again now, just not triggering jobs on the broken linux_angle_chromeos_rel_ng trybot any more. Frank, could you take this over at this point? I think we want to rename the broken linux_angle_chromeos_rel_ng trybot to something like linux_angle_ozone_rel_ng, and have it mirror chromium.gpu.fyi:GPU Linux Ozone Builder per https://chromium-review.googlesource.com/c/chromium/tools/build/+/648358 .
,
Sep 6 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/f531295aafb8b6e9d2525d6ca87771f2b4be46c3 commit f531295aafb8b6e9d2525d6ca87771f2b4be46c3 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Wed Sep 06 19:32:18 2017 Roll skia/third_party/externals/angle2/ 1a1ae0f85..cecab5920 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/1a1ae0f85eb6..cecab59200d4 $ git log 1a1ae0f85..cecab5920 --date=short --no-merges --format='%ad %ae %s' 2017-09-06 geofflang Don't use native D3D11.1 formats unless they support enough samples. 2017-09-06 kbr Remove linux_angle_chromeos_rel_ng from default bots. 2017-07-11 mradev Request a D3D11.1 device and D3D11.3 context Created with: roll-dep skia/third_party/externals/angle2 BUG=761489, 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=robertphillips@google.com Change-Id: Id987258e9519c929dc15141bbcfa88926edf0c1b Reviewed-on: https://skia-review.googlesource.com/43120 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/f531295aafb8b6e9d2525d6ca87771f2b4be46c3/DEPS
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62c23f732aa7a26110685498fe464823bb43e000 commit 62c23f732aa7a26110685498fe464823bb43e000 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Wed Sep 06 21:48:22 2017 Roll src/third_party/skia/ 4cdf3adb3..11f844e55 (6 commits) https://skia.googlesource.com/skia.git/+log/4cdf3adb3cf2..11f844e559bc $ git log 4cdf3adb3..11f844e55 --date=short --no-merges --format='%ad %ae %s' 2017-09-06 benjaminwagner Update PixelC to Android O PR6. 2017-09-06 liyuqian Convert Windows CRLF newlines back to unix ones 2017-09-06 reed add L565 to our cycle of color configs in sampleapp 2017-09-06 angle-deps-roller Roll skia/third_party/externals/angle2/ 1a1ae0f85..cecab5920 (3 commits) 2017-09-06 herb Clean up mask blur code. 2017-09-06 reed impl blitAntiV2 via mask for rasterpipeline Created with: roll-dep src/third_party/skia BUG=761489, 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Ie655edf7a1d47cfc52107efa72e4c938db3a8b2b Reviewed-on: https://chromium-review.googlesource.com/653602 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#500102} [modify] https://crrev.com/62c23f732aa7a26110685498fe464823bb43e000/DEPS
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf74aebd5654cf9d272bf890b093238bbd5c89bf commit bf74aebd5654cf9d272bf890b093238bbd5c89bf Author: Yuly Novikov <ynovikov@chromium.org> Date: Thu Sep 07 22:01:10 2017 Roll ANGLE ad6e2b6..e98e16e https://chromium.googlesource.com/angle/angle.git/+log/ad6e2b6..e98e16e BUG= 762377 ,761489 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6943a3d531255e88802adbb7f00bdf9dd0762f21 Reviewed-on: https://chromium-review.googlesource.com/655234 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#500404} [modify] https://crrev.com/bf74aebd5654cf9d272bf890b093238bbd5c89bf/DEPS
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bd0394638cd6dc161b5acb1e1ff85f18eae920ed commit bd0394638cd6dc161b5acb1e1ff85f18eae920ed Author: Frank Henigman <fjhenigman@chromium.org> Date: Thu Sep 07 22:32:32 2017 Fix and rename ANGLE Ozone trybot. Rename to linux_angle_ozone_rel_ng and mirror chromium.gpu.fyi 'GPU Linux Ozone Builder.' BUG= 762377 TBR=dpranke@chromium.org Change-Id: I2e29bd4a454a941a45d7cf5161de8f64dcd0d246 Reviewed-on: https://chromium-review.googlesource.com/656105 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/bd0394638cd6dc161b5acb1e1ff85f18eae920ed/masters/master.tryserver.chromium.angle/slaves.cfg [modify] https://crrev.com/bd0394638cd6dc161b5acb1e1ff85f18eae920ed/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/bd0394638cd6dc161b5acb1e1ff85f18eae920ed/masters/master.tryserver.chromium.angle/master.cfg
,
Sep 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/12e19644adf5cc833067365227cd3940f2a05913 commit 12e19644adf5cc833067365227cd3940f2a05913 Author: Dirk Pranke <dpranke@google.com> Date: Fri Sep 08 19:30:06 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b865e6b21d1ef7449510448aa73a5644112077a4 commit b865e6b21d1ef7449510448aa73a5644112077a4 Author: Frank Henigman <fjhenigman@chromium.org> Date: Fri Sep 08 23:57:42 2017 Fix and rename linux_angle_chromeos_rel_ng. Rename linux_angle_chromeos_rel_ng to linux_angle_chromeos_rel_ng and change it's config to match chromium.gpu.fyi 'GPU Linux Ozone Builder.' Remove it's old config which is now unused. BUG= 762377 TBR=dpranke@chromium.org Change-Id: I24c40accf7c18dcee12a4e56653d8b3e849d5385 Reviewed-on: https://chromium-review.googlesource.com/658226 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#500746} [modify] https://crrev.com/b865e6b21d1ef7449510448aa73a5644112077a4/tools/mb/mb_config.pyl
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/ad17d2a07d9a7022ab09a3671057d71242eda14e commit ad17d2a07d9a7022ab09a3671057d71242eda14e Author: Frank Henigman <fjhenigman@chromium.org> Date: Tue Sep 12 01:10:17 2017 Add linux_angle_ozone_rel_ng to CQ. This provides compile testing of ANGLE's Ozone GBM back end. BUG= 762377 Change-Id: I3e6581307e303fe81fe754799cea9c09989e0d89 Reviewed-on: https://chromium-review.googlesource.com/660380 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> [modify] https://crrev.com/ad17d2a07d9a7022ab09a3671057d71242eda14e/infra/config/cq.cfg
,
Sep 12 2017
,
Sep 12 2017
Thanks Frank. Can you also update https://chromium.googlesource.com/angle/angle/+/refs/meta/config/buildbucket.config ?
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0592154fdfaa910f6da59d414f2889cc8892148a commit 0592154fdfaa910f6da59d414f2889cc8892148a Author: Geoff Lang <geofflang@chromium.org> Date: Tue Sep 12 21:52:08 2017 Roll ANGLE 9d81537..9df395c https://chromium.googlesource.com/angle/angle.git/+log/9d81537..9df395c BUG= 762377 , chromium:764036 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ifb7bc5b6ea8c4a1495e17269e23ed74d3e36d705 Reviewed-on: https://chromium-review.googlesource.com/664078 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501413} [modify] https://crrev.com/0592154fdfaa910f6da59d414f2889cc8892148a/DEPS
,
Sep 13 2017
re #14: way ahead of you https://chromium.googlesource.com/angle/angle/+/5269ea7bc2de740044b84b0f4c72866a120a121b
,
Sep 13 2017
Excellent, thanks.
,
Sep 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/177569b1fe8b4d1c3aed6322a7e531513c2f9928 commit 177569b1fe8b4d1c3aed6322a7e531513c2f9928 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Thu Sep 14 12:45:21 2017 Roll skia/third_party/externals/angle2/ 06ef36b98..da8e257cb (38 commits) https://chromium.googlesource.com/angle/angle.git/+log/06ef36b98878..da8e257cba5a $ git log 06ef36b98..da8e257cb --date=short --no-merges --format='%ad %ae %s' 2017-09-12 mradev Number of views should match when Draw* is called 2017-09-13 geofflang Allow ReadPixels with GL_FLOAT type and EXT_color_buffer_half_float. 2017-09-12 geofflang Add GL_DEPTH_COMPONENT_24 as a depth format for surfaces. 2017-09-12 jmadill Remove Renderer11::markAllStateDirty. 2017-09-12 jmadill Lift AMD blit suppressions. 2017-09-12 jmadill Consolidate Index buffer application. 2017-09-12 jmadill D3D11: Consolidate Scissor state application. 2017-09-12 jmadill D3D11: Consolidate SRV and Sampler application. 2017-09-12 jmadill D3D11: Consolidate Viewport state application. 2017-09-12 jmadill D3D11: Consolidate Rasterizer State application. 2017-09-12 jmadill D3D11: Consolidate Blend State application. 2017-09-12 jmadill D3D11: Consolidate Depth Stencil State application. 2017-09-12 jmadill D3D11: Consolidate OMSetRenderTargets calls. 2017-09-12 jmadill Cleanup to Resource11's reset method. 2017-09-12 jmadill Context: Remove recompilation trigger impl method. 2017-09-12 jmadill Fix out-of-bounds reads in BlitFramebuffer. 2017-09-12 jmadill D3D11: Move TF state management to StateManager11. 2017-09-12 jmadill StateManager11: Add internal dirty bits for uniforms. 2017-09-12 jmadill D3D11: Consolidate constant buffer application. 2017-09-12 jmadill D3D11: Move Constant Buffer state to StateManager11. 2017-09-12 geofflang Include string.h for strncmp in ExtensionBehavior.cpp 2017-09-12 jmadill Cleanups to ResourceSerial. 2017-09-11 cwallez Allow compiling dEQP on Mac in Chromium checkout. 2017-09-11 jmadill Update Texture dirty bits documentation. 2017-09-12 mradev Fix viewport and scissor multiview updates in StatemanagerGL 2017-09-12 oetuaho GLSL: Fix initializing globals declared after main() 2017-01-09 yizhou.jiang ES31: Implement getMultisamplefv for D3D part. 2017-08-30 jie.a.chen ES31: Add glGetProgramInterfaceiv API 2017-07-14 oetuaho Refer to GLSL extensions through TExtension enum 2017-09-11 fjhenigman Add linux_angle_ozone_rel_ng to CQ. 2017-09-09 jmadill D3D: Refactor driver uniform application. 2017-09-09 jmadill ProgramD3D: Use more UniformTypeInfo. 2017-09-09 jmadill Fix EXTERNAL and 2D_ARRAY sampler type info. 2017-09-09 jmadill D3D: Only scan cached shader executable lists once. 2017-09-09 jmadill D3D11: Only update swizzles after a state change. 2017-09-09 jmadill D3D11: Implement dirty bits for texture updates. 2017-09-09 jmadill Move swizzling and program update to StateManager11. 2017-09-09 jmadill GL: Use dirty bits for texture and sampler bindings. Created with: roll-dep skia/third_party/externals/angle2 BUG= 764036 , 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=stephana@google.com Change-Id: Ic6e7cc57ddde2bfb397f5fa1b7db707f939817ad Reviewed-on: https://skia-review.googlesource.com/46440 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/177569b1fe8b4d1c3aed6322a7e531513c2f9928/DEPS
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49693a65662eb308ada90507d29b28acbb7045d9 commit 49693a65662eb308ada90507d29b28acbb7045d9 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Sep 14 16:48:20 2017 Roll src/third_party/skia/ 9b2f69b0a..d29f0e7cc (6 commits) https://skia.googlesource.com/skia.git/+log/9b2f69b0aacc..d29f0e7ccb84 $ git log 9b2f69b0a..d29f0e7cc --date=short --no-merges --format='%ad %ae %s' 2017-09-14 liyuqian Do not divide loops in PathBench 2017-09-14 caryclark name SkPixmap missing params 2017-09-13 benjaminwagner Remove redundant jobs. 2017-09-14 mtklein fix android roll 2017-09-14 robertphillips Finish restoring GrOpList DAG 2017-09-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 06ef36b98..da8e257cb (38 commits) Created with: roll-dep src/third_party/skia BUG= 764036 , 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ida4bef07cae8177e3055466dd77b11853cfd97f6 Reviewed-on: https://chromium-review.googlesource.com/667119 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501967} [modify] https://crrev.com/49693a65662eb308ada90507d29b28acbb7045d9/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jmad...@chromium.org
, Sep 6 2017