New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762372 link

Starred by 1 user
Status: Fixed
Owner:
█ pras...@chromium.org
Last visit 27 days ago
Closed: Nov 2017
Cc:
█ amineer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Optimize component stat handlers

Project Member Reported by amineer@chromium.org, Sep 6 2017 
We need to cache or pre-parse component stats on a cron timer to speed up display, which current takes ~60 seconds to process on initial load of https://chromiumdash-staging.googleplex.com/components.

Comment 1 by amineer@chromium.org, Sep 18 2017

Owner: pras...@chromium.org
Status: Assigned (was: Unassigned)
So in implementing component-graph.html, I noticed another case we'll need to take into account here.  We'd previously just directly served the "results" field for graphs directly: https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/chromiumdash/models/component_stats.py#29

However, now, the "results" field is the list of results...  *for just that component* and no subcomponents, which means it's no longer accurate.  We'll now have to ensure that when we optimize the component stats themselves, we *also* need to optimize the "results" field as well in some capacity (e.g. by creating another independent cache).

I don't think this makes things harder per se, but it does mean another place to implement.

prasadv@, can you PTAL?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/1ec2d2bc0f419654ce197a66cf0738a2b9c202e1

commit 1ec2d2bc0f419654ce197a66cf0738a2b9c202e1
Author: prasadv <prasadv@google.com>
Date: Wed Oct 18 18:41:55 2017
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/e3ccbca78277527528874f79a095749ddcddb969

commit e3ccbca78277527528874f79a095749ddcddb969
Author: prasadv <prasadv@google.com>
Date: Mon Nov 20 23:17:10 2017

Comment 4 by amineer@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment