New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762369 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in sk_abort_no_print

Project Member Reported by ClusterFuzz, Sep 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6008872916746240

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Abrt
Crash Address: 0x7fff8e436f06
Crash State:
  sk_abort_no_print
  SkArenaAlloc::ensureSpace
  append_quadratic_to_contour
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=493120:493198

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6008872916746240

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org sandeepkumars@chromium.org
Labels: Test-Predator-Wrong-CLs M-63
Owner: bunge...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "SkArenaAlloc.cpp" assigning to the concern owner who might be related.

Suspecting Commit#
https://skia.googlesource.com/skia.git/+/6229b1240aae8961a4bf34493b964d944a0a06ee

@bungeman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: bunge...@chromium.org
Owner: herb@chromium.org
Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Components: Internals>Skia
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 4 by herb@google.com, Oct 1 2017

Cc: herb@chromium.org

Comment 5 by herb@chromium.org, Oct 2 2017

Owner: senorblanco@chromium.org
The abort call is correct. The GrTessellator is calling for more than 4GB of memory. This has either happened in one large request, or many many smaller requests.

I think we have seen something like this before. Sending to Stephen
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e40c3610e4b713eb652491b8524dd1d4db117c5a

commit e40c3610e4b713eb652491b8524dd1d4db117c5a
Author: Stephen White <senorblanco@chromium.org>
Date: Tue Jan 09 18:49:37 2018

GrTessellator: set a cap on quadratic linearization.

Some pathological cases don't converge to a reasonable number of points
when using uniform linearization of quadratic points. Cap them to the
maximum which GrPathUtils supports.

Add reduced test case from crbug-762369.

BUG= 762369 

Change-Id: Icc744018e5c01a0e0fe2ec00613bdb25e49614e9
Reviewed-on: https://skia-review.googlesource.com/92721
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>

[modify] https://crrev.com/e40c3610e4b713eb652491b8524dd1d4db117c5a/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/e40c3610e4b713eb652491b8524dd1d4db117c5a/src/gpu/GrTessellator.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b3865d69eb767ec36073cd4ed3ec68ad3199e1

commit 19b3865d69eb767ec36073cd4ed3ec68ad3199e1
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Jan 11 19:01:56 2018

Roll src/third_party/skia/ 71cba8f31..ba00d226c (33 commits)

https://skia.googlesource.com/skia.git/+log/71cba8f311f1..ba00d226c3ce

$ git log 71cba8f31..ba00d226c --date=short --no-merges --format='%ad %ae %s'
2018-01-11 reed remove SK_SUPPORT_LEGACY_RECTMAKELARGEST flag
2018-01-10 ethannicholas Revert "Snap alpha for small rects"
2018-01-10 reed restore intersect methods to use old-style empty-checks on their inputs
2018-01-10 egdaniel Add valid checks in places we query isTestingOnlyBackendTexture
2018-01-10 mtklein make lua a rollable dep, roll it
2018-01-09 liyuqian Snap alpha for small rects
2018-01-10 robertphillips Remove internal files from externally visible markdown documentation
2018-01-10 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 0690e1aa3..c74ec1a5b (1 commit)
2018-01-09 fmalita [skotty] Initial solid layer support
2018-01-09 liyuqian Compare drawBounds with MakeLargest instead of isFinite
2018-01-09 mtklein support gray8 destinations on CPU
2018-01-09 fmalita [skotty] Minor tools tweaks
2018-01-09 caryclark fix external link in comment
2018-01-09 reed shrink our 'largest' so that its non-empty
2018-01-09 reed add flag for flutter
2018-01-09 reed detect bad conic weights
2018-01-09 kjlubick Refactor SerializedImageFilter to avoid duplicate code
2018-01-09 reed check for bad buffers in Unpack8
2018-01-09 reed fix bad counts deserializing SkVertices
2018-01-09 liyuqian Remove DumpHelper as the bug is fixed
2018-01-09 reed handle text error in pictureplayback
2018-01-09 egdaniel Update GrSemaphore to allow it to only be used once for signaling and once for waiting.
2018-01-09 liyuqian Remove macro in the threaded backend
2018-01-09 fmalita [skotty] Color opacity support
2018-01-09 senorblanco GrTessellator: set a cap on quadratic linearization.
2018-01-09 kjlubick Make commandline flags nicer for fuzz executable
2018-01-09 fmalita [skotty] Pre-initialize animated props
2018-01-09 fmalita [skotty] Animator scrubbing
2018-01-09 reed use 64bit math to compute is a rect is empty
2017-12-14 halcanary SkBitmap now *has* a SkPixmap.
2018-01-08 kjlubick Move 5x to proper CQ
2018-01-08 mtklein build lua tools
2018-01-09 fmalita [skotty] Pass animation frame/time as float

Created with:
  roll-dep src/third_party/skia
BUG= 762369 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I6b9c6e9d2a1b7d803da186b68f9072dabd65bd23
Reviewed-on: https://chromium-review.googlesource.com/861947
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528694}
[modify] https://crrev.com/19b3865d69eb767ec36073cd4ed3ec68ad3199e1/DEPS

Project Member

Comment 9 by ClusterFuzz, Jan 12 2018

ClusterFuzz has detected this issue as fixed in range 528641:528695.

Detailed report: https://clusterfuzz.com/testcase?key=6008872916746240

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Abrt
Crash Address: 0x7fff9dd69f06
Crash State:
  sk_abort_no_print
  SkArenaAlloc::ensureSpace
  append_quadratic_to_contour
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=493120:493198
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=528641:528695

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6008872916746240

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jan 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6008872916746240 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment