New issue
Advanced search Search tips

Issue 762362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 761493



Sign in to add a comment

[MediaRouter] Move request-queueing logic out of MediaRouterDesktop

Project Member Reported by taku...@chromium.org, Sep 6 2017

Issue description

Don't queue requests to the component extension in MediaRouterDesktop in preparation of supporting in-browser MRPs with MRDesktop.
 
Blocking: 761493
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328

commit 89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Sep 14 02:35:28 2017

Create ExtensionMediaRouteProviderProxy

- Move request queueing logic from MRDesktop to EMRPP
- Make EMRPP hold the mojo pointer to the extension MRPM
- Make MRDesktop own EMRPP
- Make MRMojoImpl hold a mojo pointer to EMRPP

Bug:  762362 
Change-Id: I9d8b4333d44736d7567f3ec77582a5584399d98e
Reviewed-on: https://chromium-review.googlesource.com/648367
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501847}
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/BUILD.gn
[add] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/extension_media_route_provider_proxy.cc
[add] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/extension_media_route_provider_proxy.h
[add] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_desktop.h
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/89b8ccf3d875cb5aa1db1ebcd7492c1b40a94328/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment