Push ninja 1.8.2 to depot_tools |
||||||||||
Issue descriptionLike issue 761691 but for 1.8.2 I follow Nico's suggestion. https://bugs.chromium.org/p/chromium/issues/detail?id=761691#c12
,
Sep 6 2017
,
Sep 6 2017
I tagged v1.8.1.
,
Sep 11 2017
Let me push binary for v1.8.2. https://github.com/ninja-build/ninja/releases/tag/v1.8.2
,
Sep 11 2017
,
Sep 11 2017
linux64
tikuta@tikuta:~/git/ninja$ git checkout v1.8.2
HEAD is now at 253e94c... v1.8.2
tikuta@tikuta:~/git/ninja$ CXX="$HOME/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="--sysroot=$HOME/chromium/src/build/linux/debian_wheezy_amd64-sysroot" LDFLAGS="--sysroot=$HOME/chromium/src/build/linux/debian_wheezy_amd64-sysroot" ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
tikuta@tikuta:~/git/ninja$ ninja
[1/1] LINK ninja
tikuta@tikuta:~/git/ninja$ ninja -t clean
Cleaning... 56 files.
tikuta@tikuta:~/git/ninja$ git checkout v1.8.2
HEAD is now at 253e94c... v1.8.2
tikuta@tikuta:~/git/ninja$ CXX="$HOME/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="--sysroot=$HOME/chromium/src/build/linux/debian_wheezy_amd64-sysroot" LDFLAGS="--sysroot=$HOME/chromium/src/build/linux/debian_wheezy_amd64-sysroot" ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
tikuta@tikuta:~/git/ninja$ ninja
[26/26] LINK ninja
tikuta@tikuta:~/git/ninja$ ./ninja all
[30/30] LINK ninja_test
tikuta@tikuta:~/git/ninja$ ./ninja_test
[236/236] ElideMiddle.ElideInTheMiddle
passed
tikuta@tikuta:~/git/ninja$ strip ninja
tikuta@tikuta:~/git/ninja$ ./ninja --version
1.8.2
tikuta@tikuta:~/git/ninja$ objdump -x ninja | grep GLIBC
0x0d696914 0x00 05 GLIBC_2.4
0x09691a75 0x00 03 GLIBC_2.2.5
0x08922974 0x00 02 GLIBCXX_3.4
tikuta@tikuta:~/git/ninja$ ls -l ninja
-rwxr-x--- 1 tikuta eng 183344 Sep 11 10:52 ninja
tikuta@tikuta:~/git/ninja$ cp ninja ~/ninja-linux64
,
Sep 11 2017
linux32
tikuta@tikuta:~/git/ninja$ git checkout v1.8.2
HEAD is now at 253e94c... v1.8.2
tikuta@tikuta:~/git/ninja$ CXX="$HOME/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="-m32 -D_FILE_OFFSET_BITS=64 --sysroot=$HOME/chromium/src/build/linux/debian_wheezy_i386-sysroot" LDFLAGS="--sysroot=$HOME/chromium/src/build/linux/debian_wheezy_i386-sysroot -m32 -L$HOME/chromium/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu -Wl,-rpath-link=$HOME/chromium/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu" ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
tikuta@tikuta:~/git/ninja$ ninja
[25/25] LINK ninja
tikuta@tikuta:~/git/ninja$ ./ninja all
[20/30] CXX build/subprocess_test.o
src/subprocess_test.cc:228:23: warning: format specifies type 'unsigned long' but the argument has type 'rlim_t' (aka 'unsigned long long') [-Wformat]
kNumProcs, rlim.rlim_cur);
^~~~~~~~~~~~~
1 warning generated.
[30/30] LINK ninja_test
tikuta@tikuta:~/git/ninja$ ./ninja_test
[236/236] ElideMiddle.ElideInTheMiddle
passed
tikuta@tikuta:~/git/ninja$ ./ninja --version
1.8.2
tikuta@tikuta:~/git/ninja$ strip ninja
tikuta@tikuta:~/git/ninja$ objdump -x ninja | grep GLIBC
0x0d696910 0x00 06 GLIBC_2.0
0x08922974 0x00 03 GLIBCXX_3.4
0x0d696914 0x00 09 GLIBC_2.4
0x0d696911 0x00 08 GLIBC_2.1
0x09691f73 0x00 05 GLIBC_2.1.3
0x0d696912 0x00 04 GLIBC_2.2
0x0d696910 0x00 02 GLIBC_2.0
tikuta@tikuta:~/git/ninja$ file ninja
ninja: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.26, stripped
tikuta@tikuta:~/git/ninja$ cp ninja ~/ninja-linux32
,
Sep 11 2017
windows binary C:\src\git\ninja>git checkout v1.8.2 HEAD is now at 253e94c... v1.8.2 C:\src\git\ninja>python configure.py warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build. wrote build.ninja. C:\src\git\ninja>C:\src\depot_tools\ninja [29/29] LINK ninja.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance C:\src\git\ninja>ninja --version 1.8.2 C:\src\git\ninja>ninja all [10/32] LINK canon_perftest.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [13/32] LINK depfile_parser_perftest.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [15/32] LINK hash_collision_bench.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [16/32] LINK clparser_perftest.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [24/32] LINK build_log_perftest.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [25/32] LINK manifest_parser_perftest.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance [32/32] LINK ninja_test.exe LINK : warning LNK4044: unrecognized option '/-driver-mode=cl'; ignored LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance C:\src\git\ninja>ninja_test to stderr MSVCHelperTest.NoReadOfStderr passed
,
Sep 11 2017
mac binary
tikuta@tikuta-macbookair:~/git/ninja$ git checkout v1.8.2
HEAD is now at 253e94c... v1.8.2
tikuta@tikuta-macbookair:~/git/ninja$ CFLAGS="-isysroot$(xcrun --sdk macosx10.12 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" LDFLAGS="-isysroot$(xcrun --sdk macosx10.12 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" CXX=$HOME/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang++ ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
tikuta@tikuta-macbookair:~/git/ninja$ ninja
[26/26] LINK ninja
tikuta@tikuta-macbookair:~/git/ninja$ ./ninja all
[30/30] LINK ninja_test
tikuta@tikuta-macbookair:~/git/ninja$ ./ninja_test
[235/235] ElideMiddle.ElideInTheMiddle
passed
tikuta@tikuta-macbookair:~/git/ninja$ otool -l ninja | grep VERSION_MIN -A 4
cmd LC_VERSION_MIN_MACOSX
cmdsize 16
version 10.6
sdk 10.12
Load command 10
tikuta@tikuta-macbookair:~/git/ninja$ strip ninja
tikuta@tikuta-macbookair:~/git/ninja$ otool -L ninja
ninja:
/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 104.1.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.50.2)
tikuta@tikuta-macbookair:~/git/ninja$ ls -l ninja
-rwxr-xr-x 1 tikuta eng 184804 Sep 11 11:32 ninja
tikuta@tikuta-macbookair:~/git/ninja$ cp ninja ~/ninja-mac
tikuta@tikuta-macbookair:~/git/ninja$ ./ninja --version
1.8.2
,
Sep 11 2017
Out of interest, can you describe the Windows build setup a bit more? I wonder if we can prevent the driver more warnings somehow. (The binary is fine as is of course, I'm just curious.)
,
Sep 11 2017
After running configure.py, I changed cxx path in build.ninja and remove /GL option from cflags.
cxx = C:\src\chromium\src\third_party\llvm-build\Release+Asserts\bin\clang-cl
cflags = /showIncludes /nologo /Zi /W4 /WX /wd4530 /wd4100 /wd4706 /wd4244 $
/wd4512 /wd4800 /wd4702 /wd4819 /wd4127 /wd4355 /wd4091 /GR- /wd4267 $
/DNOMINMAX /D_CRT_SECURE_NO_WARNINGS /D_HAS_EXCEPTIONS=0 $
/DNINJA_PYTHON="python.exe" /FS /Ox /DNDEBUG -I.
I was not able to get clang-cl version, but that is in
https://chromium.googlesource.com/chromium/src/+/f03c74c8ce1fa70d8728c8e439854fc173184708
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa57b3462009be07ccd9d2bbc8457148ce3b4992 commit aa57b3462009be07ccd9d2bbc8457148ce3b4992 Author: Takuto Ikuta <tikuta@google.com> Date: Mon Sep 11 03:46:59 2017 Update ninja to v1.8.2 New binaries for Mac, Linux32, Linux64, Windows. Also update shell script. See the bug for how these were built. The main "new" thing is fix for old cmake. Bug: 762354 , 762407 Change-Id: I4f825e357796e1cb52d2efa041bde46d68cbe152 Reviewed-on: https://chromium-review.googlesource.com/659477 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> [modify] https://crrev.com/aa57b3462009be07ccd9d2bbc8457148ce3b4992/ninja [modify] https://crrev.com/aa57b3462009be07ccd9d2bbc8457148ce3b4992/ninja-mac [modify] https://crrev.com/aa57b3462009be07ccd9d2bbc8457148ce3b4992/ninja.exe [modify] https://crrev.com/aa57b3462009be07ccd9d2bbc8457148ce3b4992/ninja-linux64 [modify] https://crrev.com/aa57b3462009be07ccd9d2bbc8457148ce3b4992/ninja-linux32
,
Sep 12 2017
Looks ninja 1.8.2 rolled. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tikuta@chromium.org
, Sep 6 2017