When Bluetooth is enabled via the Mobile Data toggle, it doesn't toggle off properly. |
|||||||||||
Issue descriptionOS: Chrome What steps will reproduce the problem? (1) Ensure Bluetooth and Mobile Data are enabled. (2) Disable Bluetooth via System Tray toggle. This will disable Mobile Data. (3) Re-enable Mobile Data via System Tray toggle. This will re-enable Bluetooth. (4) Re-disable Bluetooth via System Tray toggle. What is the expected result? Bluetooth is disabled. What happens instead? Bluetooth remains enabled and toggle automatically switches back on. The user has to click on the toggle twice to disable it for good. This is due to the fact that MobileHeaderRowView::EnableBluetooth() sets the power of the bluetooth adapter directly, rather than using BluetoothPowerController. Note: This was mentioned in crbug.com/762318 , but it is an entirely unrelated issue.
,
Sep 7 2017
From sonnysasaka: So magic tether needs to enable bluetooth when the user click on "enable mobile data". I have in mind possible 3 ways to do this: just fire BluetoothPowerController::ToggleBluetoothEnabled and ignore success/error, because adapter SetPowered shouldn't even fail, if it ever fails we should fix that fail bug instead. call BluetoothAdapter::SetPowered directly, and then save the pref manually. This way it can react correctly to SetPowered error (mobile data turn on canceled). just enable bluetooth with SetPowered without saving to pref (because it is not explicit enable bluetooth setting) I think the ideal way is solution number 2, but the easiest is solution 1. This is for M-61. What do you think?
,
Sep 8 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fd52f8a5a7c60e676bde5880c2c25bdc3d32c26 commit 8fd52f8a5a7c60e676bde5880c2c25bdc3d32c26 Author: Leslie Watkins <lesliewatkins@chromium.org> Date: Mon Sep 11 18:23:21 2017 Modified MobileHeaderRowView to use BluetoothPowerController to turn on BT with Mobile Data. This makes it easier to keep the actual powered state of the Bluetooth adapter synchronized with user prefs. Bug: 672263, 762345 Change-Id: I7a3a46217e669b8b70fe3301245c3735bc5a6be1 Reviewed-on: https://chromium-review.googlesource.com/656380 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#500980} [modify] https://crrev.com/8fd52f8a5a7c60e676bde5880c2c25bdc3d32c26/ash/system/network/network_list.cc
,
Sep 11 2017
,
Sep 11 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
Merge approved for 62.
,
Sep 12 2017
Approving merge to M61. Please merge to M62 first.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1021f63c7c9783f815cc33b537ab9fd6f64b202 commit a1021f63c7c9783f815cc33b537ab9fd6f64b202 Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Sep 12 20:51:13 2017 Modified MobileHeaderRowView to use BluetoothPowerController to turn on BT with Mobile Data. This makes it easier to keep the actual powered state of the Bluetooth adapter synchronized with user prefs. TBR=lesliewatkins@chromium.org (cherry picked from commit 8fd52f8a5a7c60e676bde5880c2c25bdc3d32c26) Bug: 672263, 762345 Change-Id: I7a3a46217e669b8b70fe3301245c3735bc5a6be1 Reviewed-on: https://chromium-review.googlesource.com/656380 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500980} Reviewed-on: https://chromium-review.googlesource.com/663942 Cr-Commit-Position: refs/branch-heads/3202@{#183} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a1021f63c7c9783f815cc33b537ab9fd6f64b202/ash/system/network/network_list.cc
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96cd02353d87434f5015f880e5f56d440d479fab commit 96cd02353d87434f5015f880e5f56d440d479fab Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Sep 12 20:54:53 2017 Modified MobileHeaderRowView to use BluetoothPowerController to turn on BT with Mobile Data. This makes it easier to keep the actual powered state of the Bluetooth adapter synchronized with user prefs. TBR=lesliewatkins@chromium.org (cherry picked from commit 8fd52f8a5a7c60e676bde5880c2c25bdc3d32c26) Bug: 672263, 762345 Change-Id: I7a3a46217e669b8b70fe3301245c3735bc5a6be1 Reviewed-on: https://chromium-review.googlesource.com/656380 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500980} Reviewed-on: https://chromium-review.googlesource.com/664082 Cr-Commit-Position: refs/branch-heads/3163@{#1175} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/96cd02353d87434f5015f880e5f56d440d479fab/ash/system/network/network_list.cc
,
Sep 12 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by khorimoto@chromium.org
, Sep 6 2017Labels: M-61
Owner: lesliewatkins@chromium.org
Status: Assigned (was: Untriaged)