New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762343 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
█ xiaoyinh@chromium.org
jdufault@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

view based lockscreen should use mojom::LoginUserInfo instead of mojom::UserInfo

Project Member Reported by xiaoyinh@chromium.org, Sep 6 2017 
LoginUserInfo has more information regarding the users in the lockscreen, like whether this user is the device owner, or if this user can be removed, etc. We should use this struct in the views implementation.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3a99dd0c6713c43eda27b92a45150a8f0563d34

commit f3a99dd0c6713c43eda27b92a45150a8f0563d34
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Tue Oct 03 22:04:11 2017

Update lockscreen views to use LoginUserInfo instead of UserInfo

Bug:  762343 
Change-Id: Iad485f0c85967ddea40e3e71a7b81d5d75bff280
Reviewed-on: https://chromium-review.googlesource.com/698885
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506197}
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/ash_strings.grd
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/lock_screen_controller.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_auth_user_view_unittest.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_password_view.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_test_base.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_test_base.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_user_view.h
[modify] https://crrev.com/f3a99dd0c6713c43eda27b92a45150a8f0563d34/ash/login/ui/login_user_view_unittest.cc

Comment 2 by xiaoyinh@chromium.org, Oct 4 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment