New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762335 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Add a flag to disable permission prompts for tests

Project Member Reported by raymes@chromium.org, Sep 6 2017

Issue description

The tests in  issue 760319  need to run without being interrupted by modal permission prompts. We might need to add a flag to automatically block permission requests that would otherwise show a prompt. This may need to be done before we can remove the modals feature flag in order to allow the tests to continue to work.
 
Owner: timloh@chromium.org
Tim: can I assign to you since this is related to the modals work (we'll have to do it before we can remove the flag).
Cc: perezju@chromium.org
Thanks for looking into this! I'll keep an eye when the work is ready to use the flag as needed on Telemetry tests.
Cc: rhalavati@chromium.org
Components: Privacy
Adding privacy.

Comment 4 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1ef68c36541addce91a689c8de5c2d3b81a9fb

commit 7c1ef68c36541addce91a689c8de5c2d3b81a9fb
Author: Timothy Loh <timloh@chromium.org>
Date: Fri Nov 17 02:50:15 2017

Add --deny-permission-prompts switch for suppressing permission prompts

This patch adds a command-line switch, --deny-permission-prompts, which
will suppress all permission prompts. This is intended for testing
purposes, where prompts (in particular modal prompts on Android) may
be irrelevant to but get in the way of tests. This is necessary for
telemetry tests, which currently fallback to infobar prompts on Android.

Bug:  762335 
Change-Id: I6ad36b81ce6404da2c5e141b5fdca2692f37af35
Reviewed-on: https://chromium-review.googlesource.com/773768
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517260}
[modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/common/chrome_switches.cc
[modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/common/chrome_switches.h

Nice! If the chrome-side work is done, you can assign back to me to make the necessary changes in Telemetry.

Comment 7 by timloh@chromium.org, Nov 20 2017

Owner: perezju@chromium.org
Status: Assigned (was: Available)
Re-assigning to you, thanks!
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/ed32dd50b3276262cb0ce22691b8f263955b0577

commit ed32dd50b3276262cb0ce22691b8f263955b0577
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Wed Dec 20 15:52:08 2017

[Telemetry] Use --deny-permission-prompts

Use the chrome flag --deny-permission-prompts to suppress all permission
prompts by denying them. This allows to remove a workaround that used to
turn all modal prompts into infobars so they don't block the execution
of a story.

Flag was added by:
https://chromium-review.googlesource.com/c/chromium/src/+/773768

Bug:  chromium:762335 
Change-Id: I22656df95a250c1243e2790295d84d874b070e6f
Reviewed-on: https://chromium-review.googlesource.com/836553
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/ed32dd50b3276262cb0ce22691b8f263955b0577/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
[modify] https://crrev.com/ed32dd50b3276262cb0ce22691b8f263955b0577/telemetry/telemetry/internal/browser/browser_options.py

Status: Fixed (was: Started)

Sign in to add a comment