Issue metadata
Sign in to add a comment
|
Add a flag to disable permission prompts for tests |
||||||||||||||||||||||||
Issue descriptionThe tests in issue 760319 need to run without being interrupted by modal permission prompts. We might need to add a flag to automatically block permission requests that would otherwise show a prompt. This may need to be done before we can remove the modals feature flag in order to allow the tests to continue to work.
,
Sep 6 2017
Thanks for looking into this! I'll keep an eye when the work is ready to use the flag as needed on Telemetry tests.
,
Sep 26 2017
Adding privacy.
,
Nov 10 2017
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c1ef68c36541addce91a689c8de5c2d3b81a9fb commit 7c1ef68c36541addce91a689c8de5c2d3b81a9fb Author: Timothy Loh <timloh@chromium.org> Date: Fri Nov 17 02:50:15 2017 Add --deny-permission-prompts switch for suppressing permission prompts This patch adds a command-line switch, --deny-permission-prompts, which will suppress all permission prompts. This is intended for testing purposes, where prompts (in particular modal prompts on Android) may be irrelevant to but get in the way of tests. This is necessary for telemetry tests, which currently fallback to infobar prompts on Android. Bug: 762335 Change-Id: I6ad36b81ce6404da2c5e141b5fdca2692f37af35 Reviewed-on: https://chromium-review.googlesource.com/773768 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#517260} [modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/common/chrome_switches.cc [modify] https://crrev.com/7c1ef68c36541addce91a689c8de5c2d3b81a9fb/chrome/common/chrome_switches.h
,
Nov 17 2017
Nice! If the chrome-side work is done, you can assign back to me to make the necessary changes in Telemetry.
,
Nov 20 2017
Re-assigning to you, thanks!
,
Dec 20 2017
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/ed32dd50b3276262cb0ce22691b8f263955b0577 commit ed32dd50b3276262cb0ce22691b8f263955b0577 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Wed Dec 20 15:52:08 2017 [Telemetry] Use --deny-permission-prompts Use the chrome flag --deny-permission-prompts to suppress all permission prompts by denying them. This allows to remove a workaround that used to turn all modal prompts into infobars so they don't block the execution of a story. Flag was added by: https://chromium-review.googlesource.com/c/chromium/src/+/773768 Bug: chromium:762335 Change-Id: I22656df95a250c1243e2790295d84d874b070e6f Reviewed-on: https://chromium-review.googlesource.com/836553 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/ed32dd50b3276262cb0ce22691b8f263955b0577/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py [modify] https://crrev.com/ed32dd50b3276262cb0ce22691b8f263955b0577/telemetry/telemetry/internal/browser/browser_options.py
,
Dec 20 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by raymes@chromium.org
, Sep 6 2017