Issue metadata
Sign in to add a comment
|
Latest chrome will render tables differently than chrome 59 with flexbox
Reported by
tris...@myvr.com,
Sep 5 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36 Steps to reproduce the problem: 1. Visit https://codepen.io/TristanBrotherton/pen/jLRQpB in chrome 59 2. Visit https://codepen.io/TristanBrotherton/pen/jLRQpB in chrome 60 3. The behaviour of the table is different. What is the expected behavior? The behaviour of the table should be the same, with the small col taking up full height. What went wrong? The latest version of chrome does not extend the height of the table cell to be the full height of its sibling td. See comparative render between the two versions, attached. Did this work before? Yes 59 Does this work in other browsers? Yes Chrome version: 60.0.3112.113 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Thank you for your hard work.
,
Sep 6 2017
,
Sep 26 2017
The behaviour of Edge, FF, and CHrome is consistent now. See my screenshots. Reopening to get your feedback.
,
Sep 26 2017
Thanks - but this is still an issue. I have updated the pen to show a difference in rendering between Chrome and Firefox and edge. (I added a height of 100% to the tr) https://codepen.io/TristanBrotherton/pen/jLRQpB Firefox and IE will show the full height, Chrome does not.
,
Sep 26 2017
Thank you for providing more feedback. Adding requester "robhogan@gmail.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 26 2017
We're matching Edge now but not FF. We could still be correct. I'll look into it.
,
Sep 26 2017
There is also a discrepancies with how this is displayed using divs that are styled with CSS to behave as a table. In the pen below, we can achieve the desired result, and Chrome will render the div full height in the table cell https://codepen.io/TristanBrotherton/pen/GMWZob
,
Sep 27 2017
,
Oct 2 2017
The difference between https://codepen.io/TristanBrotherton/pen/jLRQpB and https://codepen.io/TristanBrotherton/pen/GMWZob is the 100% height on the table in the latter. We should be rendering that one like https://codepen.io/TristanBrotherton/pen/jLRQpB too. After some clarification with the css-tables spec author and the CSSWG, we only treat cells as having a height that percent values can resolve against if the cell has an explicitly specified height. For example, if the cell has a percent height but nothing in its container chain to resolve that percentage against it doesn't have an explicitly specified height. That's why it's correct for us to render the .container and the .label in your tests as though it were 'auto' rather than 100%. 687551 has all the discussion. The bug for us here is to fix https://codepen.io/TristanBrotherton/pen/GMWZob to match our rendering in the other test, rather than the other way round. Firefox's rendering is wrong I believe, again see issue 687551 for the gory detail.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d9417940fca2d9edc013f02dbc5ba3b7cccc3c commit 65d9417940fca2d9edc013f02dbc5ba3b7cccc3c Author: Robert Hogan <robhogan@gmail.com> Date: Mon Oct 09 18:46:11 2017 Treat percent height cells with nothing to resolve against as auto tables/mozilla/bugs/ bug113424 .html covers the quirky behaviour, in non-quirk mode we should continue to respect the rule that a percent-height cell with nothing to resolve against is auto. Bug: 762330 Change-Id: I8c7d97d23c75b7eb56a3d93637444d0ccada8d9b Reviewed-on: https://chromium-review.googlesource.com/700520 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#507427} [add] https://crrev.com/65d9417940fca2d9edc013f02dbc5ba3b7cccc3c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-and-percent-height-table.html [modify] https://crrev.com/65d9417940fca2d9edc013f02dbc5ba3b7cccc3c/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
,
Oct 17 2017
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e7701a83830e5e68640af9dbb5932c73cf74ef3 commit 9e7701a83830e5e68640af9dbb5932c73cf74ef3 Author: Robert Hogan <robhogan@gmail.com> Date: Tue Jan 09 23:06:18 2018 Revert "Treat percent height cells with nothing to resolve against as auto" This reverts commit 65d9417940fca2d9edc013f02dbc5ba3b7cccc3c. Reason for revert: Per crbug.com/798478 the behaviour introduced with this patch was correct per the spec but turns out to be not interoperable. So revert for now and check interoperability again when spec is clarified. Original change's description: > Treat percent height cells with nothing to resolve against as auto > > tables/mozilla/bugs/ bug113424 .html covers the quirky behaviour, > in non-quirk mode we should continue to respect the rule that a > percent-height cell with nothing to resolve against is auto. > > Bug: 762330 > Change-Id: I8c7d97d23c75b7eb56a3d93637444d0ccada8d9b > Reviewed-on: https://chromium-review.googlesource.com/700520 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507427} TBR=robhogan@gmail.com,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 762330, 798478 Change-Id: I07e0b9cfd8f0884f316ee98b51f75fa22b360229 Reviewed-on: https://chromium-review.googlesource.com/858017 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#528156} [modify] https://crrev.com/9e7701a83830e5e68640af9dbb5932c73cf74ef3/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-and-percent-height-table.html [modify] https://crrev.com/9e7701a83830e5e68640af9dbb5932c73cf74ef3/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
,
Jan 29 2018
,
Jan 29 2018
This is going to be broken again starting in Chrome 65. See issue 798478 for some spec discussion and link to updated spec that the fix for this issue will need to obey. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Sep 6 2017Components: Blink>Layout>Table
Labels: -Pri-2 hasbisect-per-revision Triaged-ET M-63 Needs-Triage-M60 OS-Linux OS-Windows Pri-1
Owner: robho...@gmail.com
Status: Assigned (was: Unconfirmed)