New issue
Advanced search Search tips

Issue 762326 link

Starred by 1 user
Status: Fixed
Owner:
minch@chromium.org
Closed: Sep 2017
Cc:
omrilio@chromium.org
shibasheikh@chromium.org
mccanny@chromium.org
newcomer@chromium.org
zork@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Swiping up on opened status area tray should not open the launcher

Project Member Reported by minch@chromium.org, Sep 5 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Switch to tablet mode.
(2) Swipe up on the status area to open corresponding tray bubble (eg, swipe up on system tray to open system tray bubble)
(3) Swipe up again on the status area tray. (eg, system tray)

What is the expected result?
Tray bubble keep opened, nothing happen.

What happens instead?
The second swipe close the tray bubble, open the launcher instead.

Comment 1 by minch@chromium.org, Sep 6 2017 

omrillo@, newcomer@, should the second swipe close the opened system tray?
Since, click the tray when system tray is opened will close the system tray.

Comment 2 by newcomer@chromium.org, Sep 6 2017

Cc: shibasheikh@chromium.org
Also adding shibasheikh@ because this is a UX consideration.

Comment 3 by minch@chromium.org, Sep 14 2017

Cc: mccanny@chromium.org sgabr...@chromium.org
mccanny@, sgabriel@, what it should be for this case? Thanks.

Comment 4 by sgabr...@chromium.org, Sep 14 2017 

swiping up on a already open system tray shouldn't do anything. 
Currently we set expectations weirdly by enabling the manipulation of the launcher when the sys tray is open. We should only allow control of the sys tray within the sys tray "swipe box".

Comment 5 by minch@chromium.org, Sep 15 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c19320186f7963ce9e9eb176bf00a3c4b66a7377

commit c19320186f7963ce9e9eb176bf00a3c4b66a7377
Author: MinChen <minch@chromium.org>
Date: Fri Sep 15 17:17:29 2017

Disable the tray view dragging if the associated tray bubble is opened.

Changes,
1. Disable the tray view dragging if the app list is opened.
2. Disable the tray view dragging if the associated tray bubble is opened.

Test: SystemTrayTest*
Bug:  762326 
Change-Id: I630165196dd831b8e0962c3a57e43dcc6590efbf
Reviewed-on: https://chromium-review.googlesource.com/668138
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502291}
[modify] https://crrev.com/c19320186f7963ce9e9eb176bf00a3c4b66a7377/ash/system/tray_drag_controller.cc
[modify] https://crrev.com/c19320186f7963ce9e9eb176bf00a3c4b66a7377/ash/system/tray_drag_controller.h

Comment 7 by minch@chromium.org, Sep 15 2017

Labels: Touch-Friendly-Launcher Hotlist-Merge-Review
Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment