I looked at the button strokes on Retina and they look fine. The problem, I believe, is the stroke value is good for Retina because the button stroke 1px. My original report and screenshot occurred on my desktop machine which is not a Retina screen.

Somehow the Views code needs to detect when it's drawing to non-Retina and use a lighter stroke value in that case.

I can probably hack this in. But if we want something for Harmony like this (i.e. something based on retina/non-retina), we need to run it by UX.

It's probably "unexpectedly dark" versus --secondary-ui-md since the stroke color is chosen based on text color, and the PRIMARY text color is lighter under Harmony.

> I can probably hack this in.

Please do.

> But if we want something for Harmony like this (i.e. something based on retina/non-retina), we need to run it by UX.

This exact problem is discussed in Harmony  Issue 660414  (except the 1px line and stroke color make non-Retina look OK but bad on Retina). I see that bug is marked fixed - I need to take a look at the result to see if the button strokes are still invisible on Retina (looking right now they are noticeably better but I need to look at it again in the morning).

https://chromium-review.googlesource.com/651946

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1dafe6de22865f9525143501e4aa44a9a56354

commit 3d1dafe6de22865f9525143501e4aa44a9a56354
Author: Trent Apted <tapted@chromium.org>
Date: Wed Sep 06 03:38:58 2017

Use a lighter MD button stroke on Mac, but not on Retina, when not Harmony.

The button stroke is based on text color, which changes under Harmony.

Without full Harmony, the text is black and the button stroke looks
too dark on non-retina Mac screens. Compensate, and allow us to explore
whether we want special retina/non-retina logic for the button stroke
on Mac for full Harmony as well.

Bug:  762321 
Change-Id: I7818478423a7aeb0706d107305605f6541d4a092
Reviewed-on: https://chromium-review.googlesource.com/651946
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499875}
[modify] https://crrev.com/3d1dafe6de22865f9525143501e4aa44a9a56354/ui/views/controls/button/md_text_button.cc

Verified the issue on mac os 10.12.6 (Non-Retina) using chrome M63 #63.0.3208.0 and issue seems fixed.

Strokes of the buttons in the dialog are not dark and lightened up.

Attached screenshot for reference.

Adding Te-Verified labels.

Thanks!

Thanks! I checked retina as well for 63.0.3208.0 - verified the fix is working as intended. Requesting merge of r499875 to m62.

branch: 3202

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2962288f50d73ae269ef7af2efa77e3c2406418

commit b2962288f50d73ae269ef7af2efa77e3c2406418
Author: Trent Apted <tapted@chromium.org>
Date: Sun Sep 10 23:56:15 2017

[merge-m62] Use a lighter MD button stroke on Mac, but not on Retina, when not Harmony.

The button stroke is based on text color, which changes under Harmony.

Without full Harmony, the text is black and the button stroke looks
too dark on non-retina Mac screens. Compensate, and allow us to explore
whether we want special retina/non-retina logic for the button stroke
on Mac for full Harmony as well.

Bug:  762321 
Change-Id: I7818478423a7aeb0706d107305605f6541d4a092
Reviewed-on: https://chromium-review.googlesource.com/651946
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499875}(cherry picked from commit 3d1dafe6de22865f9525143501e4aa44a9a56354)
Reviewed-on: https://chromium-review.googlesource.com/658579
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#112}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/b2962288f50d73ae269ef7af2efa77e3c2406418/ui/views/controls/button/md_text_button.cc

Verified this issue on MacBookAir 10.12.6 using chrome latest dev #62.0.3202.18. Observed the permission bubble buttons are not too dark as expected. Hence adding TE-Verified label.

Thanks!

Deleted: Screen Shot 2017-09-12 at 1.11.40 PM.png 21.9 KB

	Screen Shot 2017-09-12 at 1.11.40 PM.png 21.9 KB View Download