New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762318 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disabling Mobile Data during an active Tether connection may cause crash

Project Member Reported by lesliewatkins@chromium.org, Sep 5 2017

Issue description

OS: Chrome

What steps will reproduce the problem?
(1) Enable Mobile Data and Bluetooth.
(2) Connect to Tether network.
(3) Disable Mobile Data via the toggle in the System Tray.

What is the expected result?
Bluetooth and Mobile Data will be disabled, active Tether connection will be disconnected.

What happens instead?
Crash.
 
palogs.txt
5.0 KB View Download
backtrace.txt
3.8 KB View Download
Labels: M-61 OS-Chrome
Hey Leslie - can you look into what is causing the first attempt to fail and add the relevant logs/information here?
The failure of the first attempt is due to an unrelated issue, which has been filed at  crbug.com/762345 .
Leslie, were you using any debug code when you got this stack trace?
No, as far as I know.
backtrace.txt
5.9 KB View Download
Owner: khorimoto@chromium.org
Status: Assigned (was: Untriaged)
logs.txt
3.2 KB View Download
Description: Show this description
Summary: Disabling Mobile Data during an active Tether connection may cause crash (was: Disabling Bluetooth during an active Tether connection may cause crash)
More generally, this crash occurs when Mobile Data is disabled while a Tether network is connected. I've updated the summary and description to reflect this new information.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a98f47e043a5581eb610b58b047a23ba207a145

commit 7a98f47e043a5581eb610b58b047a23ba207a145
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Sep 13 17:28:24 2017

[CrOS Tether] Fix a crash during shutdown.

The crash was caused because NetworkConfigurationRemover was destroyed
before WifiHotspotDisconnector. Side note: there is a bug filed
( crbug.com/761532 ) to clean this up. It does not scale, and it is prone
to errors like this crash.

Bug:  762318 , 672263
Change-Id: Ie91976af96fde96dcd4bdf0902b26a8c6fae7300
Reviewed-on: https://chromium-review.googlesource.com/664481
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501676}
[modify] https://crrev.com/7a98f47e043a5581eb610b58b047a23ba207a145/chromeos/components/tether/initializer_impl.cc

Labels: Merge-Request-61 Merge-Request-62
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-62 Merge-Approved-62
Consider this merge approved for 62, pending the CL making it past the Chrome PFQ on ToT.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 and M62.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14103a0e23a2e5d54ecd0ee1f8b0c472ba85a691

commit 14103a0e23a2e5d54ecd0ee1f8b0c472ba85a691
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Sep 13 19:03:30 2017

[CrOS Tether] Fix a crash during shutdown.

The crash was caused because NetworkConfigurationRemover was destroyed
before WifiHotspotDisconnector. Side note: there is a bug filed
( crbug.com/761532 ) to clean this up. It does not scale, and it is prone
to errors like this crash.

TBR=khorimoto@google.com

(cherry picked from commit 7a98f47e043a5581eb610b58b047a23ba207a145)

Bug:  762318 , 672263
Change-Id: Ie91976af96fde96dcd4bdf0902b26a8c6fae7300
Reviewed-on: https://chromium-review.googlesource.com/664481
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501676}
Reviewed-on: https://chromium-review.googlesource.com/665598
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#207}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/14103a0e23a2e5d54ecd0ee1f8b0c472ba85a691/chromeos/components/tether/initializer_impl.cc

Status: Fixed (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9954055c59d6462c34cf3ed0850ed343e6964042

commit 9954055c59d6462c34cf3ed0850ed343e6964042
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Sep 13 19:06:36 2017

[CrOS Tether] Fix a crash during shutdown.

The crash was caused because NetworkConfigurationRemover was destroyed
before WifiHotspotDisconnector. Side note: there is a bug filed
( crbug.com/761532 ) to clean this up. It does not scale, and it is prone
to errors like this crash.

TBR=khorimoto@google.com

(cherry picked from commit 7a98f47e043a5581eb610b58b047a23ba207a145)

Bug:  762318 , 672263
Change-Id: Ie91976af96fde96dcd4bdf0902b26a8c6fae7300
Reviewed-on: https://chromium-review.googlesource.com/664481
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501676}
Reviewed-on: https://chromium-review.googlesource.com/665365
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1188}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9954055c59d6462c34cf3ed0850ed343e6964042/chromeos/components/tether/initializer_impl.cc

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 19 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment