New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762298 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
ooo
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8% regression in memory.top_10_mobile at 498450:498629

Project Member Reported by briander...@chromium.org, Sep 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=762298

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ae85c5b4421941df2a35f4ba99e467f9f1f44826e0357b01cf9d8ebe4ecb6e0a


Bot(s) for this bug's original alert(s):

android-one
Cc: junov@chromium.org
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author junov@chromium.org ===

Hi junov@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Justin Novosad
  Commit : 3241713daaab793054c46061d7dcf1d37ee0cd54
  Date   : Wed Aug 30 21:42:17 2017
  Subject: Removing obsolete comment in WebGLRenderingContextBase

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/https_mobile_twitter_com_justinbieber_skip_interstitial_true
  Change       : 0.65% | 22877790.8571 -> 23035267.4286

Revision             Result                   N
chromium@498449      22877791 +- 365255       14      good
chromium@498539      22587844 +- 922105       9       good
chromium@498584      22490426 +- 1383373      14      good
chromium@498607      22594655 +- 1328972      14      good
chromium@498618      22608601 +- 1715803      21      good
chromium@498620      22559473 +- 1196630      14      good
chromium@498621      23060477 +- 804867       9       bad       <--
chromium@498624      23138984 +- 122161       6       bad
chromium@498629      23035267 +- 1085648      14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969252355690220560


For feedback, file a bug with component Speed>Bisection
Owner: ----
Status: Available (was: Assigned)
No way junov's patch caused the regression. Going to kick off another bisect.
Cc: hunyadym@chromium.org
Owner: hunyadym@chromium.org
Status: Assigned (was: Available)

=== Auto-CCing suspected CL author hunyadym@chromium.org ===

Hi hunyadym@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Marton Hunyady
  Commit : 829219f40ad218b323c06ba79d048c7d0c3c8bc5
  Date   : Wed Aug 30 21:46:44 2017
  Subject: Listen to onCompleted instead of onResponseStarted of authView.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/https_mobile_twitter_com_justinbieber_skip_interstitial_true
  Change       : 0.79% | 22883325.3333 -> 23064232.0

Revision             Result                   N
chromium@498449      22883325 +- 1289178      21      good
chromium@498539      22558522 +- 1326032      14      good
chromium@498584      22861919 +- 1094522      14      good
chromium@498606      22609869 +- 1544508      21      good
chromium@498618      22568372 +- 1534459      21      good
chromium@498621      22473043 +- 331351       6       good
chromium@498623      22432765 +- 594435       9       good
chromium@498624      23074131 +- 621975       6       bad       <--
chromium@498629      23064232 +- 743551       14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969179851274815616


For feedback, file a bug with component Speed>Bisection
Owner: briander...@chromium.org
My CL only changes Chrome OS-only code - that can't be the reason of this regression. Reassigning.
Cc: perezju@chromium.org
Status: WontFix (was: Assigned)
This recovered, so WontFix-ing, but also cc-ing perezju in case there's anything we want to investigate here: bisect got pretty reproducible results for two different and very unlikely CLs.

Sign in to add a comment