Evtest in crosh |
||
Issue descriptionThis bug tracks the status of enabling evtest in crosh. evtest prints input events from evdev. Having it in crosh will make bug triage much easier on release build. Enabling evtest straight forward might expose too much information (including keboard events, mouse movement). Thus this patch ( https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/637144 ) is applied to add a safe mode for evtest. When evtest is called with --safe, it will sanitize sensitive events. To move on, we need to enable evtest in release build and add it to crosh. When it is called from crosh, all parameters should be ignored and it will be only invoked with "--safe". In this way, it will let user select "/dev/input/event#", print sanitized events.
,
Sep 6 2017
is the --safe a passive thing that doesn't otherwise impact/block the event devices ?
,
Sep 6 2017
No, it won't impact/block the events to chrome. --grab will do that, but it won't be allowed.
,
Sep 6 2017
sounds fine then, thanks
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f9e47f3211bf6ffb8848be5e4676b57bd824564c commit f9e47f3211bf6ffb8848be5e4676b57bd824564c Author: Jingkui Wang <jkwang@google.com> Date: Wed Sep 06 23:54:30 2017 evtest: Add usage info to safe mode patch This cl updates the --safe mode patch with usage info and patch description. BUG= chromium:762297 TEST=local build and evtest Change-Id: Ibf8f3f319e62daf956073471e72e284689112e26 Reviewed-on: https://chromium-review.googlesource.com/653207 Commit-Ready: Jingkui Wang <jkwang@google.com> Tested-by: Jingkui Wang <jkwang@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/f9e47f3211bf6ffb8848be5e4676b57bd824564c/app-misc/evtest/evtest-1.31-r3.ebuild [modify] https://crrev.com/f9e47f3211bf6ffb8848be5e4676b57bd824564c/app-misc/evtest/files/1.31-add-safe-flag.patch
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eb9307ddcdf7bd8a143c658cd0bef0015556449c commit eb9307ddcdf7bd8a143c658cd0bef0015556449c Author: Jingkui Wang <jkwang@google.com> Date: Fri Sep 08 04:21:43 2017 Add evtest to chromium os build This patch adds evtest to chromium os ebuild. It is hidden behind USE=evdev_input. BUG= chromium:762297 TEST=local build Change-Id: I73870d6f79ea02301005248879fadab5a8beca89 Reviewed-on: https://chromium-review.googlesource.com/653591 Commit-Ready: Jingkui Wang <jkwang@google.com> Tested-by: Jingkui Wang <jkwang@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/eb9307ddcdf7bd8a143c658cd0bef0015556449c/virtual/target-chromium-os/target-chromium-os-1-r74.ebuild [modify] https://crrev.com/eb9307ddcdf7bd8a143c658cd0bef0015556449c/virtual/target-chromium-os/target-chromium-os-1.ebuild
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0faf757d3f5157f87270d014dac9ad28ec9da9b1 commit 0faf757d3f5157f87270d014dac9ad28ec9da9b1 Author: Jingkui Wang <jkwang@google.com> Date: Thu Sep 14 00:13:55 2017 evtest: Update safe mode patch to round timestamp This patch update the safe mode patch the round timestamp to seconds. It will avoid possible side channel attack. BUG= chromium:762297 TEST=local build and evtest Change-Id: Iececf70c7cf5798a92d42015a2844c18d712049e Reviewed-on: https://chromium-review.googlesource.com/664255 Commit-Ready: Jingkui Wang <jkwang@google.com> Tested-by: Jingkui Wang <jkwang@google.com> Reviewed-by: Dmitry Torokhov <dtor@chromium.org> [modify] https://crrev.com/0faf757d3f5157f87270d014dac9ad28ec9da9b1/app-misc/evtest/files/1.31-add-safe-flag.patch [rename] https://crrev.com/0faf757d3f5157f87270d014dac9ad28ec9da9b1/app-misc/evtest/evtest-1.31-r4.ebuild
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4c982df88d7055ce777345b8868a91ac5662130a commit 4c982df88d7055ce777345b8868a91ac5662130a Author: Jingkui Wang <jkwang@google.com> Date: Fri Sep 15 23:59:23 2017 crosh: Enable evtest in crosh This patch adds evtest to crosh. Evtest will run in "safe" mode, which will not print private info. BUG= chromium:762297 TEST=local test Change-Id: I6e26087996ed242905ba1aab0c73c6e0474bec49 Reviewed-on: https://chromium-review.googlesource.com/650606 Commit-Ready: Jingkui Wang <jkwang@google.com> Tested-by: Jingkui Wang <jkwang@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4c982df88d7055ce777345b8868a91ac5662130a/crosh/crosh
,
Oct 4 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted