New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762251 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

do not send hit-test data if the list hasn't changed from last submit

Project Member Reported by riajiang@chromium.org, Sep 5 2017

Issue description

Putting the mouse on the omnibox gives us blinking cursor, which submits a new compositor frame and a new hit-test data list all the time. This is a special case but it might make sense to check hit-test data list diff in HitTestProviderAura in general and don't send a new list if it's the same as the old one.
 
Cc: sky@chromium.org
I guess the proposal here is: empty hit-test data implies the latest hit-test should be used instead. I like this. I think supporting this in the service-side would be easy. On the client side, however, this may be tricky. We do not currently have a mechanism for tracking when hit-test data has changed, so we would need to add something there. It's probably not overly difficult, e.g. any change in window-hierarchy, bounds, visibility, and shape should invalidate the hit-test region. But there may be edge cases we need to be careful about.
Sadrul and I discussed about this offline, summary here: we think supporting it in ClientLayerTreeFrameSink/ HitTestDataProviderAura would be a good first-step, i.e. keep the previous list and check the new list against the old one before submitting, do not submit the list if it's the same as the old one. This way we save all the transporting time, and checking against the list should cost the same or less compared to aggregating the list in HitTestAggregator.
Status: Started (was: Available)
Actually, do we know how often we are sending unchanged hit-test region list? Is it true that this cursor case is one of the only few that does that? If it's far more common to send updated hit-test region list, then checking against the previous list every time would be unnecessarily expensive. In that case maybe supporting it on the client side is indeed required?

Comment 5 by sadrul@chromium.org, Sep 19 2017

Owner: riajiang@chromium.org
We will be sending hittest data for each visual update (e.g. hover update on buttons, menus etc.). So, n the worst case, for each mouse move, which can be fairly frequent.

The right-est thing to do of course would be to not have to generate the hittest data at all if nothing changes.

Comment 6 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash-Mus
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Labels: -Proj-Mustash
Cc: zandershah@google.com
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1002fa88140000

All of the runs failed. The most common error (10/20 runs) was:
HTTPException: HTTP status code 400: {"error": {"message": "CIPD package path is required. Use \".\" to install to run dir."}}
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16c4ba20140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\ity16chx\\tmpxtq9zftelemetry\\histograms.json'
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11f0abf4140000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/170e6517e40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it653lxg\\tmpslu1mrtelemetry\\histograms.json'
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17ebe5a7e40000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11aaa430140000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1550daa0140000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/148c01abe40000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15ee1d8c140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16329547e40000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11bb0b1c140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11c58517e40000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12cd9936140000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17738c32140000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1182164c140000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13569832140000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13a28eca140000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/142acaac140000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/142edff8140000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/129cf11e140000
Project Member

Comment 54 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d1a299da673ba215bb76cb9cb116c0d46f05df0

commit 5d1a299da673ba215bb76cb9cb116c0d46f05df0
Author: Alexander Shah <zandershah@google.com>
Date: Thu Dec 13 01:08:42 2018

viz: Do not send hit-test data unless it has been updated.

Aggregation only occurs when new hit-test data has been
submitted.

R=rjkroege@chromium.org

Bug: 762251
Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796
Reviewed-on: https://chromium-review.googlesource.com/c/1294838
Commit-Queue: Alexander Shah <zandershah@google.com>
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616135}
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/test/layer_tree_test.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/common/hit_test/hit_test_region_list.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/5d1a299da673ba215bb76cb9cb116c0d46f05df0/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom

Project Member

Comment 55 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ce3da3c67857a07008ba2155c14b5d47ac53ce

commit f0ce3da3c67857a07008ba2155c14b5d47ac53ce
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Dec 13 02:44:48 2018

Revert "viz: Do not send hit-test data unless it has been updated."

This reverts commit 5d1a299da673ba215bb76cb9cb116c0d46f05df0.

Reason for revert: cc_unittests failing on multiple builders

Original change's description:
> viz: Do not send hit-test data unless it has been updated.
> 
> Aggregation only occurs when new hit-test data has been
> submitted.
> 
> R=​rjkroege@chromium.org
> 
> Bug: 762251
> Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796
> Reviewed-on: https://chromium-review.googlesource.com/c/1294838
> Commit-Queue: Alexander Shah <zandershah@google.com>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ria Jiang <riajiang@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616135}

TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org,riajiang@chromium.org,zandershah@google.com

Change-Id: Icad5086a846890552af8734e315eeaa382923a8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762251,  914642 
Reviewed-on: https://chromium-review.googlesource.com/c/1375291
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616178}
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/layer_tree_test.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ba67d6bae54a039a9fcdaf535536820aa098fcb

commit 4ba67d6bae54a039a9fcdaf535536820aa098fcb
Author: Alexander Shah <zandershah@google.com>
Date: Fri Dec 14 00:36:57 2018

Reland viz: Do not send hit-test data unless it has been updated.

Aggregation only occurs when new hit-test data has been
submitted.

R=riajiang@chromium.org

TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org

Bug: 762251
Change-Id: Ibe35d794f449c391be99f91980d80976cf2e5f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1294838
Commit-Queue: Alexander Shah <zandershah@google.com>
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616135}
Reviewed-on: https://chromium-review.googlesource.com/c/1376723
Cr-Commit-Position: refs/heads/master@{#616525}
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/common/hit_test/hit_test_region_list.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/4ba67d6bae54a039a9fcdaf535536820aa098fcb/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom

Project Member

Comment 57 by bugdroid1@chromium.org, Jan 7

Labels: merge-merged-3664
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae8a6114164ad8e930bb52dc276212a2c6866f9

commit bae8a6114164ad8e930bb52dc276212a2c6866f9
Author: Ria Jiang <riajiang@chromium.org>
Date: Mon Jan 07 18:50:49 2019

Revert "Reland viz: Do not send hit-test data unless it has been updated."

This reverts commit 4ba67d6bae54a039a9fcdaf535536820aa098fcb.

Reason for revert: possible culprit CL for https://bugs.chromium.org/p/chromium/issues/detail?id=917816, reverting for M73 dev release

Original change's description:
> Reland viz: Do not send hit-test data unless it has been updated.
> 
> Aggregation only occurs when new hit-test data has been
> submitted.
> 
> R=​riajiang@chromium.org
> 
> TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org
> 
> Bug: 762251
> Change-Id: Ibe35d794f449c391be99f91980d80976cf2e5f3c
> Reviewed-on: https://chromium-review.googlesource.com/c/1294838
> Commit-Queue: Alexander Shah <zandershah@google.com>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ria Jiang <riajiang@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#616135}
> Reviewed-on: https://chromium-review.googlesource.com/c/1376723
> Cr-Commit-Position: refs/heads/master@{#616525}

TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org,riajiang@chromium.org,zandershah@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 762251
Change-Id: I98f902b8a5dcd6c00130a9f2fc85abd0cbc4ea89
Reviewed-on: https://chromium-review.googlesource.com/c/1398389
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3664@{#4}
Cr-Branched-From: 74a02c1be085f0ae1754f199606f2750178d7834-refs/heads/master@{#620241}
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/test/layer_tree_test.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/common/hit_test/hit_test_region_list.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/bae8a6114164ad8e930bb52dc276212a2c6866f9/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom

Sign in to add a comment