Content_Unittests-Viz: GpuVSyncBeginFrameSourceTest |
||||||
Issue descriptionGpuVSyncBeginFrameSourceTest has dependencies on: - viz::BeginFrameObserverBase - viz::BeginFrameArgs Find out how the Viz process split impacts this test, and update.
,
Sep 19 2017
Since these are testing the file content/browser/compositor/gpu_vsync_begin_frame_source.h should that also be considered for moving to viz_unittests? Or is this a case, where the functionality we are testing is in the wrong spot, but we want the base file to remain.
,
Nov 8 2017
Migrating from Internals>Viz to Internals>Services>Viz.
,
Dec 14 2017
I think most of GpuVsyncBeginFrameSource will cease to exist with viz. Some of this functionality might have to move into components/viz/service/ but it becomes an ExternalBeginFrameSource essentially. I've added the blocking bug for that.
,
Mar 12 2018
As discussed in triage I'm assigning to kylechar@. Once the replacement for GpuVsyncBeginFrameSource is used we will need an equivalent test coverage.
,
Mar 27 2018
This doesn't actually require any work. GpuVsyncBeginFrameSource will just go to away with VizDisplayCompositor and we'll have an ExternalBeginFrameSource in the GPU process. GpuVsyncBeginFrameSource + GpuVsyncBeginFrameSourceTest can just be deleted then. I'll leave the bug open to track that deletion of the tests when we are done.
,
Jun 7 2018
penghuang deleted this test in https://crrev.com/c/1065808. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kylec...@chromium.org
, Sep 6 2017