[Chrome Home] Increase padding above omnibox for half, full & selected states in Chrome Home button condition |
||||||||||||||||
Issue descriptionThe sister bug for crbug.com/757623. We should figure out what type of padding we want for the button condition for Chrome Home which has no drag handle.
,
Sep 6 2017
Adding Fine-Pri-2.5 to match sister bug.
,
Sep 21 2017
Hannah, what do you think about making the omnibox background 36dp in both the expand button and pull handle condition? This is a pretty easy change, and makes the toolbar consistent with the bookmarks/downloads/history search.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62397c64aabecd07c7e161bf7be99f2f692a945c commit 62397c64aabecd07c7e161bf7be99f2f692a945c Author: Theresa Wellington <twellington@google.com> Date: Fri Sep 22 18:39:23 2017 [Home] Always use expand button in accessibility mode - Always use expand button in accessibility mode - General accessibility polish - Use consistent location bar background height when expand button is showing BUG=766880, 762231 TBR=tedchoc@chromium.org Change-Id: Ib1f726de4f1b1790241be0c316a517c72cf9e26d Reviewed-on: https://chromium-review.googlesource.com/677789 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#503805} [modify] https://crrev.com/62397c64aabecd07c7e161bf7be99f2f692a945c/chrome/android/java/OWNERS [modify] https://crrev.com/62397c64aabecd07c7e161bf7be99f2f692a945c/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/62397c64aabecd07c7e161bf7be99f2f692a945c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/62397c64aabecd07c7e161bf7be99f2f692a945c/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/62397c64aabecd07c7e161bf7be99f2f692a945c/chrome/android/java/strings/android_chrome_strings.grd
,
Sep 22 2017
Hannah, if you like the screenshots in #3 when the expand button is showing, then we can mark this as "fixed".
,
Oct 4 2017
hannahs@ - ping, can we close this out?
,
Oct 4 2017
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by twelling...@chromium.org
, Sep 6 2017