New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762230 link

Starred by 1 user
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
vmp...@chromium.org
█ nednguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Task

Blocked on:
issue 762705
issue 763119
Blocking:
issue 756117



Sign in to add a comment

Explore using snap-it to switch r_and_r top 25 to use static html.

Project Member Reported by wkorman@chromium.org, Sep 5 2017 
Notes from chat discussion. Thought is that this could be easier than working through any remaining WPRGo and re-recording issues. One obvious tradeoff is any snap-it bugs, see for example https://github.com/progers/snap-it/issues/1

Patch https://codereview.chromium.org/3010063002

Follow script instructions in change description. Can use --interactive for pages that require login. Snapshot html for the top 25 pages. Put all files in a dir under tools/perf/page_sets

Run ./upload_to_google_storage.py in depot_tools (same bucket as existing benchmark script, I think it's the partner bucket).

Check in the SHA files. Telemetry will handle the rest.

Revise rasterize_and_record_micro benchmark script to:
- set a serving dir for the page set
- replace all URLs with "file://..."

Theoretically, https://en.wikipedia.org/wiki/Bob%27s_your_uncle

Comment 1 by wkorman@chromium.org, Sep 5 2017

Blocking: 756117
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef4d06c741ff008140ea948676b11303a8505c8

commit 2ef4d06c741ff008140ea948676b11303a8505c8
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Sep 06 06:03:16 2017

Add static snapshots of top 25 page set.

Uploaded with:

% upload_to_google_storage.py -b chrome-partner-telemetry *.html

Bug:  762230 
Change-Id: Ia9236ce1d451430504a36619e33e96dd71e338e8
Reviewed-on: https://chromium-review.googlesource.com/651348
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#499891}
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/README.md
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/amazon.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/blogger.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/booking.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/cnn.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/ebay.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/espn.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/facebook.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/gmail.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/google.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/googlecalendar.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/googledocs.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/googleimagesearch.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/googleplus.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/linkedin.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/pinterest.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/techcrunch.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/twitter.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/weather.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/wikipedia.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/wordpress.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/yahooanswers.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/yahoogames.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/yahoonews.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/yahoosports.html.sha1
[add] https://crrev.com/2ef4d06c741ff008140ea948676b11303a8505c8/tools/perf/page_sets/static_top_25/youtube.html.sha1

Comment 3 by wkorman@chromium.org, Sep 6 2017

Blockedon: 762705
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad5b55c5478b65eae433d4539e20e7a6c315dcb

commit 1ad5b55c5478b65eae433d4539e20e7a6c315dcb
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Sep 06 23:41:07 2017

Add a page set for the static top 25 pages.

Bug:  762230 
Change-Id: I23aa5f3fe85df4f3856dfd5eab1422fe0d84f501
Reviewed-on: https://chromium-review.googlesource.com/653601
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500119}
[add] https://crrev.com/1ad5b55c5478b65eae433d4539e20e7a6c315dcb/tools/perf/page_sets/static_top_25_pages.py
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/259a2fef8e656fcb18868995d2ad1e84be90c21b

commit 259a2fef8e656fcb18868995d2ad1e84be90c21b
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Sep 06 23:44:42 2017

Ignore large static html files under top 25 page set data directory.

There are other html files elsewhere under page_sets/ that we do want
to track, else we would add this to the higher level
page_sets/.gitignore file.

Bug:  762230 
Change-Id: If2a5998fe0cbae22c73ea93591071fbf41f8d0ad
Reviewed-on: https://chromium-review.googlesource.com/653604
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500125}
[add] https://crrev.com/259a2fef8e656fcb18868995d2ad1e84be90c21b/tools/perf/page_sets/static_top_25/.gitignore
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a87e954ef8849a96627048487928b381d4b37ed

commit 2a87e954ef8849a96627048487928b381d4b37ed
Author: Walter Korman <wkorman@chromium.org>
Date: Thu Sep 07 18:42:38 2017

Switch rasterize_and_record_micro benchmark to use static page set.

Bug:  762230 
Change-Id: I9ae8b541eecebdc30e3d412558a5a746e93bb046
Reviewed-on: https://chromium-review.googlesource.com/653999
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500342}
[modify] https://crrev.com/2a87e954ef8849a96627048487928b381d4b37ed/tools/perf/benchmarks/rasterize_and_record_micro.py

Comment 7 by nedngu...@google.com, Sep 7 2017

Blockedon: 763119

Comment 8 by wkorman@chromium.org, Sep 27 2017

Status: Fixed (was: Started)
Brief update -- this is done, though there are two remaining breakout items (the blocked-on bugs here) around improving snapping of iframes and external images. Closing this as the benchmark has been switched over, leaving the other bugs to be worked on separately.

Ned has improved the iframe issue, likely enough to get us by for now, with his recent work.

I will be working on the image issue in the next week or so.

There are also some timeouts to be addressed in issue 768010.
►

Sign in to add a comment