New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762209 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Oct 2017
Cc:
█ briander...@chromium.org
shend@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.8%-15% regression in blink_perf.css at 496048:497200

Project Member Reported by briander...@chromium.org, Sep 5 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 5 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=762209

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a38d3403f3ecb282ba74af3cd063e9e18185fcdf3c5ed5118aed784e6c384674


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 6 2017

Cc: shend@chromium.org
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author shend@chromium.org ===

Hi shend@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Darren Shen
  Commit : 26d5c0d9218faabcdf678e29c867ee90a971efe2
  Date   : Thu Aug 24 04:38:42 2017
  Subject: [CSSParser] Do not invalidate ranges when consuming from streams.

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : SelectorCountScaling/SelectorCountScaling
  Change       : 14.37% | 10.2755499615 -> 8.83439725571

Revision             Result                   N
chromium@496047      10.2755 +- 0.592531      9      good
chromium@496624      10.1742 +- 0.729339      6      good
chromium@496912      10.0895 +- 0.716584      6      good
chromium@496948      10.3881 +- 0.357232      7      good
chromium@496950      10.4182 +- 0.470734      5      good
chromium@496951      8.91517 +- 0.734267      7      bad       <--
chromium@496953      8.87032 +- 0.606818      5      bad
chromium@496957      8.86088 +- 0.646486      6      bad
chromium@496966      9.02966 +- 0.263956      6      bad
chromium@496984      8.73546 +- 0.682358      6      bad
chromium@497056      8.99389 +- 0.4906        7      bad
chromium@497200      8.8344 +- 0.438565       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969256382249848736


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Sep 7 2017 


=== Auto-CCing suspected CL author shend@chromium.org ===

Hi shend@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Darren Shen
  Commit : ca7c1bf8eb877f562f5a38e745aea68874876d81
  Date   : Tue Sep 05 23:47:45 2017
  Subject: [CSSParser] Switch some parsing functions to use streams.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : SelectorCountScaling/SelectorCountScaling
  Change       : 24.66% | 7.09257190352 -> 5.34369192128

Revision             Result                   N
chromium@499661      7.09257 +- 0.470116      6      good
chromium@499736      6.99766 +- 0.486157      5      good
chromium@499773      6.72174 +- 0.766463      6      good
chromium@499792      6.97597 +- 0.547183      6      good
chromium@499801      7.09148 +- 0.320079      6      good
chromium@499802      7.20915 +- 0.350527      6      good
chromium@499803      5.24195 +- 0.754911      6      bad       <--
chromium@499804      5.81098 +- 0.407816      6      bad
chromium@499806      5.95682 +- 0.577656      6      bad
chromium@499810      5.34369 +- 0.58188       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969153438926348352


For feedback, file a bug with component Speed>Bisection

Comment 6 by shend@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)
Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/676366
►

Sign in to add a comment