Namely add to DetectedText.idl [1]: [SameObject] readonly attribute FrozenArray<Point2D> cornerPoints; which was introduced in commit [2], and wire it to the implementations for Mac [3] and Android [4] [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl?q=Detectedtext.idl&sq=package:chromium&dr [2] https://github.com/WICG/shape-detection-api/commit/23785c15f578cd442d655d138b616f04791a7f0a [3] https://cs.chromium.org/chromium/src/services/shape_detection/text_detection_impl_mac.mm?l=36 [4] https://cs.chromium.org/chromium/src/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java?l=38
Can i take this issue? thanks.
junwei.fu@: please go ahead, I assigned the bug to you. As a possibly unnecessary reminder, please add Layout tests and unittests where appropriate :-)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86bc62c9debaf42c81cf69c48b58420fa3dfd04e commit 86bc62c9debaf42c81cf69c48b58420fa3dfd04e Author: junweifu <junwei.fu@intel.com> Date: Fri Sep 15 02:16:51 2017 ShapeDetection: Extend DetectedText API to retrieve texts corner points Add |cornerPoints| attribute in DetectedText.idl that is 4 corner points in clockwise direction starting with top-left and is not necessarily a rectangle due to possible perspective distortions. The |cornerPoints| associated code is copy-pasted from the QR/barcode detection parts. BUG= 762172 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: Ic3872e637f04bc1d337398531afef8c7f0dfd4b3 Reviewed-on: https://chromium-review.googlesource.com/658564 Reviewed-by: Oliver Chang <ochang@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#502133} [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/services/shape_detection/android/javatests/src/org/chromium/shape_detection/TextDetectionImplTest.java [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/Source/modules/shapedetection/DetectedText.h [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl [modify] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
Comment 1 by mcasas@chromium.org
, Sep 5 2017Components: Blink>ImageCapture
Labels: ShapeDetection OS-Android
Status: Available (was: avila)