cros chrome-sdk failed with KeyError: u'version' |
||||||||
Issue descriptionchrome at d8e81e01aaf9d788411884dd8eb3156ecb3787a8 r499741 (which has third_party/chromite at f542336f1ad33cbf13fe2fdecd90a7908d9e46e1) jamescook@jamescook:/w/chrome/src (prefdocs)$ cros chrome-sdk --board=link 13:59:09: ERROR: cros chrome-sdk failed before completing. 13:59:09: ERROR: u'version' or jamescook@jamescook:/w/chrome/src (prefdocs)$ cros chrome-sdk --board=link --log-level=debug 14:01:49: DEBUG: Cache dir lookup. 14:01:49: DEBUG: Configured cache_dir to '/w/chrome/.cros_cache' 14:01:49: DEBUG: RunCommand: /w/chrome/.cros_cache/common/gsutil_4.19.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' ls 14:01:50: DEBUG: Loading LKGM version from "chromeos/CHROMEOS_LKGM": 9913.0.0 14:01:50: INFO: Starting Goma. 14:01:50: DEBUG: RunCommand: python2 goma_ctl.py ensure_start in /w/chrome/.cros_cache/common/goma+2 using /tmp/goma_jamescook as tmpdir Using goma VERSION=138 (latest) GOMA version 3656d9a3f5c6ba9f441e70522c80c2ee53132bc9@1502706589 goma is already running. 14:01:51: DEBUG: RunCommand: ./gomacc port in /w/chrome/.cros_cache/common/goma+2 14:01:51: INFO: Goma is started on port 8088 14:01:51: ERROR: cros chrome-sdk failed before completing. cros: Unhandled exception: Traceback (most recent call last): File "/w/chrome/src/third_party/chromite/bin/cros", line 168, in <module> DoMain() File "/w/chrome/src/third_party/chromite/bin/cros", line 164, in DoMain commandline.ScriptWrapperMain(FindTarget) File "/w/chrome/src/third_party/chromite/lib/commandline.py", line 910, in ScriptWrapperMain ret = target(argv[1:]) File "/w/chrome/src/third_party/chromite/scripts/cros.py", line 65, in main code = _RunSubCommand(subcommand) File "/w/chrome/src/third_party/chromite/scripts/cros.py", line 50, in _RunSubCommand return subcommand.Run() File "/w/chrome/src/third_party/chromite/cli/cros/cros_chrome_sdk.py", line 1019, in Run toolchain_url=self.options.toolchain_url) as ctx: File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__ return self.gen.next() File "/w/chrome/src/third_party/chromite/cli/cros/cros_chrome_sdk.py", line 379, in Prepare self.toolchain_path, toolchain_url % {'target': target_tc}) KeyError: u'version' I've tried clearing my sdk cache, but that doesn't help. achuith, can you triage? I'm blocked on this. Same root cause as issue 761496 ?
,
Sep 5 2017
I'll take a look. I have an interview starting in a few minutes so I won't be able to look at this for another hour. Can you try reverting: https://chromium.googlesource.com/chromium/src/+/cfff8af77862c5ed1ca99be7490e6d9c66c5f7e2 Or go to 8a6e00a6bf94230bbe4b24d7ad1e0cb6d1eea09a
,
Sep 5 2017
just pick an older CrOS version until ToT syncs up
,
Sep 5 2017
For completeness, these are the values of self.toolchain_path and toolchain_url in the last stack frame: gs://chromiumos-sdk 2017/09/%%(target)s-%(version)s.tar.xz Reverting cfff8af77862c5ed1ca99be7490e6d9c66c5f7e2 (LKGM bump to 9913) takes me back to 9899 and makes simplechrome work for me.
,
Sep 5 2017
Note: you can always pass --version= to 'cros chrome-sdk'. This is the same root cause as issue 761496 .
,
Sep 5 2017
i'll leave it to you guys to decide whether to revert the automatic roll or push a new one or something else :)
,
Sep 5 2017
I'm not sure that any of us understand the root cause here well enough to make a decision (I certainly don't). All I know is that the format in the metadata.json files parsed by 'cros chrome-sdk' changed which breaks simple chrome. I don't know where / how those files are generated.
,
Sep 5 2017
the files were badly generated ( issue 761496 ), but that's fixed now in ToT. there might have been some bad rolls along the way.
,
Sep 5 2017
,
Sep 6 2017
So amd64-generic works, kevin and link don't work (due to the metadata format inconsistency noted above by Steven), and chell falls back to 9911. I'm inclined to just wait for the SDK builders to catch up, unless anyone has objections. We can also revert my change if people prefer this.
,
Sep 6 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14378ca40c38d37c303fda15b2ec959be8cda7d9 commit 14378ca40c38d37c303fda15b2ec959be8cda7d9 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Sep 06 20:33:31 2017 Update chromeos LKGM to 9916.0.0 Works on the following boards: kevin, falco, chell, link, wolf, amd64-generic BUG= chromium:762641 , chromium:762169 TEST=kevin, falco, chell, link, wolf, amd64-generic Change-Id: I4904cee23c0e0996d2e082a4c7baf80d87de3565 Reviewed-on: https://chromium-review.googlesource.com/653918 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#500070} [modify] https://crrev.com/14378ca40c38d37c303fda15b2ec959be8cda7d9/chromeos/CHROMEOS_LKGM
,
Sep 6 2017
I believe we should be past the point of the metadata.json format mismatch with version 9916.
,
Jan 22 2018
,
Jan 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jamescook@chromium.org
, Sep 5 2017