Massive number of failures on smoothness benchmarks |
|||||||||||||||||
Issue descriptionThere are a lot of smoothness benchmark tests failing now. Victor: can you triage fixing/disabling these failing tests? Failing benchmarks: smoothness.top_25_smooth smoothness.desktop_tough_pinch_zoom_cases smoothness.gpu_rasterization.top_25_smooth smoothness.key_silk_cases smoothness.maps smoothness.tough_filters_cases smoothness.tough_webgl_ad_cases These smoothness failures can be found in https://sheriff-o-matic.appspot.com/chromium.perf
,
Sep 5 2017
Also: the smoothness.maps failures that started on the Android Nexus5 Perf bot in this build: https://luci-milo.appspot.com/buildbot/chromium.perf/Android%20Nexus5%20Perf/224 are due to shards expiring because there isn't enough capacity.
,
Sep 5 2017
Could the re-recording of some of the WPR archives caused the apparent mismatch between the test and the recorded page in https://bugs.chromium.org/p/chromium/issues/detail?id=762165#c1 ?
,
Sep 5 2017
This is quite surprising. Did they start to fail since last Thursday or today? I'll try to repro this locally. Will revert if confirmed to be a bad conversion.
,
Sep 5 2017
Is the regression range by sheriff-o-matic accurate? If so, the regression started long after the conversion has been committed. Could it be one of the catapult roll?
,
Sep 5 2017
Re #2: That benchmark's device was offline and was fixed earlier today in t/28507470. The latest build should start getting results in.
,
Sep 12 2017
We are seeing the top_25_smooth failure on ChromeOS - https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=telemetry_Benchmarks.smoothness.top_25_smooth&suite=&daysBack=30&board=&architecture=&boardFamily=&buildConfig=&reason=&version=&milestone=63&dut=
,
Sep 12 2017
On the following bots: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20Pro%2010.11%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20Mini%208GB%2010.12%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf?numbuilds=200 (probably more, I stopped looking after all of those) The smoothness.top_25_smooth failures started when https://chromium-review.googlesource.com/c/chromium/src/+/546615 landed. The failures are all google pages: Unexpected Failures: * smoothness.top_25_smooth/Docs (1 open document tab) * smoothness.top_25_smooth/http://www.youtube.com * smoothness.top_25_smooth/https://plus.google.com/110031535020051778989/posts * smoothness.top_25_smooth/https://www.google.com/calendar/ * smoothness.top_25_smooth/https://www.google.com/search?q=cats&tbm=isch CC-ing owner of CL.
,
Sep 12 2017
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_10-2017-09-12_10-19-1135701.png Screenshot from the failed youtube test. Looks like it is indeed getting stuck trying to log in.
,
Sep 12 2017
fkackr@: seems like we need to revert your CL
,
Sep 12 2017
Reverting CL in https://chromium-review.googlesource.com/c/chromium/src/+/663946
,
Sep 12 2017
,
Sep 13 2017
The revert didn't go through cleanly :-( Robert, can you fix pages whose login broken because of your CL?
,
Sep 13 2017
Issue 764756 has been merged into this issue.
,
Sep 13 2017
The smoothness.key_silk_cases seem to be an unrelated problem. Spun off into its own bug at crbug.com/764825
,
Sep 13 2017
This seems to account for quite a bit of the redness on the waterfall right now... Just looking at the last failure on each bot this accounts for (note, this is just me quickly going through all the bots to estimate impact of this bug. I'm not saying that all these failures are 100% caused by this, I just highly suspect that they are): Nexus 5x: 3/6 failures Nexus 5: 2/6 failures Nexus 6: 3/7 failures Nexus 7: 3/9 failures A1: 3/10 failures Nexus 5X webview: 2/5 failurs Nexus 6 Webview: 2/5 failures (problem with dromeao benchmarks causing high failure rates on windows) win 10 high-dpi: 2/10 failures win 10 perf: 2/10 failures win 8 perf: 2/8 failures win 7 perf: 2/8 failures win 7 x64: 2/9 failures win ATI: 2/8 failures win intel: 2/8 failures win nvidia: Exceptions on bot make it hard to tell.. estimated 2 benchmarks though mac 10.11: 2/2 failures mac 10.12: 1/1 failures mac retina: 1/2 failures mac pro 10.11: 2/3 failures mac air 10.11: 1/5 failures mac mini 8GB: 2/3 failures Linux: Exceptions on the bot make it hard to tell.. estimated 2/3 failures
,
Sep 15 2017
,
Sep 15 2017
Sorry I was on a plane and haven't had a chance to look into this yet. It's the weekend here but I will try to have a look at this soon. Do we know why we're just now noticing that my July 1st patch broke the tests? Is it that we recently started running it again? Or was it just rolled in now?
,
Sep 15 2017
Hmmm. I think the real cause was this cl: https://chromium-review.googlesource.com/c/chromium/src/+/648252 which contains a link to your cl: https://chromium-review.googlesource.com/c/chromium/src/+/546615 So.. I'm not sure if its your CL, or this other CL that was based off your CL. CCing the author of that CL. Sorry that no one noticed this earlier.
,
Sep 15 2017
Oh yes, that patch updated the auth call for YouTube without rerecording it which seems like it may have been the problem.
,
Sep 15 2017
I will revert Walter's CL given that rasterize_and_record_micro now uses static HTML
,
Sep 15 2017
,
Sep 16 2017
I'm re-recording these sites and will upload a patch soon.
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc commit 26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc Author: Victor Miura <vmiura@chromium.org> Date: Sat Sep 16 06:43:40 2017 telemetry: Re-record top_25 google sites, and fix login flow. This fixes and re-enables loading of the following page stories: * top_25_smooth/Docs (1 open document tab) * top_25_smooth/http://www.youtube.com * top_25_smooth/https://plus.google.com/110031535020051778989/posts * top_25_smooth/https://www.google.com/calendar/ * top_25_smooth/https://www.google.com/search?q=cats&tbm=isch TBR=nednguyen@google.com BUG= 762165 Change-Id: I4c39637b1c02a40653e2c11dcb3cca0ea6d34070 Reviewed-on: https://chromium-review.googlesource.com/670064 Reviewed-by: Victor Miura <vmiura@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#502496} [modify] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/benchmarks/smoothness.py [add] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_007.wprgo.sha1 [add] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_008.wprgo.sha1 [modify] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_009.wprgo.sha1 [add] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_010.wprgo.sha1 [modify] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_011.wprgo.sha1 [modify] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/data/top_25_smooth.json [modify] https://crrev.com/26f31fe066aa26cbbd9cd2a1ea2cf32d4b52edfc/tools/perf/page_sets/login_helpers/google_login.py
,
Oct 16 2017
,
Oct 27 2017
I believe this can be closed?
,
Oct 30 2017
,
Nov 2 2017
I'm still seeing failures on Win 7 Perf and Win 7 x64 Perf: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%207%20x64%20Perf https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%207%20x64%20Perf/builds/1391 https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_x64_Perf%2F1391%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.top_25_smooth_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%207%20Perf?numbuilds=200 https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%207%20Perf/builds/1409 https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf%2F1409%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.top_25_smooth_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout
,
Nov 2 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b45d15ba8b6fa1e66d1aa24b636b44792a804e61 commit b45d15ba8b6fa1e66d1aa24b636b44792a804e61 Author: Charlie Andrews <charliea@chromium.org> Date: Wed Nov 15 22:11:36 2017 Disable failing smoothness.top_25_smooth stories TBR=rnephew@chromium.org, vmiura@chromium.org Bug: 762165 , 736099 Change-Id: I8c0cfb765015a3efdc26ae4a548dd5164b4d483f Reviewed-on: https://chromium-review.googlesource.com/769431 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Reviewed-by: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#516851} [modify] https://crrev.com/b45d15ba8b6fa1e66d1aa24b636b44792a804e61/tools/perf/benchmarks/smoothness.py
,
Dec 4 2017
Moving Infra>Client>Android -> Infra>Client>Chrome+OS=Android
,
Dec 4 2017
,
Feb 5 2018
,
Mar 5 2018
,
Aug 14
The following pages have now been re-recorded, and the corresponding expectations removed: rendering.desktop/google_calendar rendering.desktop/google_plus rendering.desktop/youtube rendering.desktop/google_image_search rendering.desktop/google_docs |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by kbr@chromium.org
, Sep 5 2017