Issue metadata
Sign in to add a comment
|
[Full Screen Mode] Menu Bar doesn't disappear when a Menu Bar menu was open before |
||||||||||||||||||||||
Issue descriptionChrome Version: Chromium Snapshot Build 499688 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable Bright Dock/Menu Mode (2) Open a Chromium new window (3) Enable "Always show Toolbar in Full Screen" (4) Go into Full Screen Mode (5) Move the mouse cursor to the top of the screen, so that the Menu Bar appears (6) Click on one Menu Bar Item so the the menu appears [7] Now move the mouse cursor to the middle of the screen [8] Do a left click so that the menu disappears What is the expected result? The Menu Bar should disappear, because the mouse cursor is in the middle of the screen. What happens instead? The Menu bar is still visible and doesn't disappear Please find attached a screencast. If you need more information, please let me know. Thanks, Mehmet
,
Sep 14 2017
Adding a blocker-label, since this is a regression. Caused by: https://chromium-review.googlesource.com/641999
,
Sep 14 2017
,
Sep 20 2017
Friendly ping for an update on this issue marked as Beta Blocker.
,
Sep 20 2017
I'm working on this now.
,
Sep 20 2017
Great, thank you. If you have any further questions regarding the steps to reproduce this issue, please let me know. BTW: It would be great, if you could also have a look at issue 762153 since both issues seem to be related. Thank you very much in advance.
,
Sep 25 2017
sdy@, Friendly ping to get an update on this issue as it is marked as beta blocker . Thank you..!
,
Sep 27 2017
,
Sep 27 2017
,
Sep 28 2017
The NextAction date has arrived: 2017-09-28
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3f912579a8d9352aac24d915d1407887b591c03 commit a3f912579a8d9352aac24d915d1407887b591c03 Author: Sidney San Martín <sdy@chromium.org> Date: Thu Sep 28 21:42:48 2017 Fix toolbar and menu bar getting stuck open in fullscreen after certain actions. - Move menu bar locking into ScopedMenuBarLock to get a stronger guarantee that the menu bar is left unlocked on exiting fullscreen. - Use a different test for whether there should be a tracking area. - Lock and unlock the menu bar from -[FullscreenToolbarMouseTracker mouseEntered:] and -mouseExited: directly. Also don't remove the tracking area in mouseExited:, this caused a case where the tracking area got removed while the menu bar was still visible. - Remove a couple of unit tests which mostly repeated existing tests but also tested assumptions that are no longer valid. It might be good to add an interactive UI test in the future, or a unit test for FullscreenToolbarMouseTracker. Background ---------- The menu bar and toolbar would get stuck if you enter fullscreen and either: 1. Move the mouse to the top of the screen, then move it down over the toolbar, then back up to the top of the screen, then down to the middle of the screen. Cause: the tracking was incorrectly removed in mouseExited:. 2. Move the mouse to the top of the screen, then open a menu, move the mouse down to the middle of the screen, and click to close the menu. Cause: The menu bar overlaps the window when it drops down. Moving the mouse over the menu bar fired mouseExited:, but the old code used -mouseInsideTrackingArea, which still returned YES because the mouse was technically inside the tracking area even though mouseExited: had already fired and wouldn't fire again. Bug: 762160 Change-Id: Ia15228be8d62e16a66a712f78bd1c8fe62dbef26 Reviewed-on: https://chromium-review.googlesource.com/688414 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505168} [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm [add] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/scoped_menu_bar_lock.h [add] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/scoped_menu_bar_lock.mm [add] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/browser/ui/cocoa/scoped_menu_bar_lock_unittest.mm [modify] https://crrev.com/a3f912579a8d9352aac24d915d1407887b591c03/chrome/test/BUILD.gn
,
Sep 29 2017
Perfectly fixed. Thank you very much. Works as expected now in latest Chrome Canary 63.0.3227.0 on macOS 10.12.6. Also the issue with the enabled Dark Menu/Dock setting is fixed (merged issue 762153 ). Thank you sdy@ :-)
,
Sep 29 2017
Issue 758349 has been merged into this issue.
,
Sep 29 2017
Thanks for catching this, mehmet@! \o/
,
Sep 29 2017
,
Oct 6 2017
Issue 768188 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Sep 5 20171.9 MB
1.9 MB Download