I'd like to see the mock given M63 time frame.

Apologies for the delay. 

Here are the resources:

!xD spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZbHF01iRNpsj/files/MCHbtQVoQ2HCZdm6RgQJhc4W
Proposal deck: https://docs.google.com/presentation/d/1YFG1SVgffgi2tcf5gRPMERBaem9hrLAjp7-XiNl4jG0/edit#slide=id.g26c06356aa_0_73

Please let me know if you have any questions.

Should the margin be dp, not px? I think the most of the Files app styles are specified in px.

Although we use 'px' in CSS files, these values actually work as DIP (=dp).

Using dp is proper in the visual spec. When copying the values to CSS files, let's use 'px' for consistency.

Ah. Thank you. Can we just replace dp with px while copying the values?

2017/10/03 21:10 "fukino via monorail" <monorail+v2.1393151049@chromium.org

Yes we can :)

Thank you!

2017/10/03 21:14 "fukino via monorail" <monorail+v2.1393151049@chromium.org

Marianne kindly took this issue. Thanks!

To summarize the changes:
- Add <- button
- Change the margin

Looking into the code.

mcirimele@ : Are there reasons for limiting this change to media files?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711ce10ff9c70eff63caaba0db11ea038ffbaa5b

commit 711ce10ff9c70eff63caaba0db11ea038ffbaa5b
Author: mariannet <mariannet@google.com>
Date: Fri Oct 13 07:29:00 2017

Allow images to take up more space.

Let images take up more space.

Bug:  762159 
Test: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifb907cdcdfec586bc4209d5a08fa9bab3b23f958
Reviewed-on: https://chromium-review.googlesource.com/718160
Commit-Queue: Marianne Thieffry <mariannet@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508635}
[modify] https://crrev.com/711ce10ff9c70eff63caaba0db11ea038ffbaa5b/ui/file_manager/file_manager/foreground/elements/files_quick_view.css

The cl that I submitted includes this change for all quick view items and not just media files. As soon as mcirimele@ has responded, this issue will either be closed or receive a fix.

You need to add the left arrow button to close Quick View.
https://docs.google.com/presentation/d/1YFG1SVgffgi2tcf5gRPMERBaem9hrLAjp7-XiNl4jG0/edit#slide=id.g26c06356aa_0_59

I think we can use the same margin as the info button. Maria can confirm.

@mariannet - Yes, having this change for all quick view items would be ideal (as you have implemented it), thanks for calling that out. 

@oka Yes, let's use the same margin as the info button. It's 16pd for 1x I believe. 

Right, that's the second time I forgot about that button - let me add it!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f849a47358629debb995225c988924856d1fdab

commit 8f849a47358629debb995225c988924856d1fdab
Author: mariannet <mariannet@google.com>
Date: Tue Oct 17 13:21:31 2017

Introduce a back button to FilesApp QuickView.

Bug:  762159 
Test: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3c8c8dfe6f81a121e5b0c08ee6c28f5074d9ca35
Reviewed-on: https://chromium-review.googlesource.com/722461
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Marianne Thieffry <mariannet@google.com>
Cr-Commit-Position: refs/heads/master@{#509374}
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/ui/file_manager/file_manager/foreground/elements/icons.html
[modify] https://crrev.com/8f849a47358629debb995225c988924856d1fdab/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Button added, bug fixed!