VR tests that involve screen taps failing on K/L |
|||||||
Issue descriptionThis appears to be similar to Issue 711035 and Issue 710624 , which were fixed a while ago. Pretty regularly, the VR tests that tap on the screen are failing due to not having the INJECT_EVENTS permission, implying that there's something else being drawn over the screen. Previously, this was due to the immersive mode dialogue being drawn over Chrome, but that was fixed by setting anr_show_background to false during provisioning, which is still being done. The first instance I've found of this is from Thursday August 31 (https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests/builds/11376). I don't see anything suspicious in the blame list, although it could also be from an earlier batch.
,
Sep 5 2017
Hmm, this could be related to bug 761077 where we're seeing screens getting tapped when they shouldn't be. Maybe same root cause here. Have you seen the tests failing on only a specific swarming bot?
,
Sep 5 2017
It doesn't look like it's tied to any particular set of bots. The past 6 failures occurred on: K build267-m1--device5 https://chromium-swarm.appspot.com/bot?id=build267-m1--device5&sort_stats=total%3Adesc build82-b4--device1 https://chromium-swarm.appspot.com/bot?id=build82-b4--device1&sort_stats=total%3Adesc build83-b4--device7 https://chromium-swarm.appspot.com/bot?id=build83-b4--device7&sort_stats=total%3Adesc build58-b4--device5 https://chromium-swarm.appspot.com/bot?id=build58-b4--device5&sort_stats=total%3Adesc L build134-b1--device1 https://chromium-swarm.appspot.com/bot?id=build134-b1--device1&sort_stats=total%3Adesc build134-b1--device2 https://chromium-swarm.appspot.com/bot?id=build134-b1--device2&sort_stats=total%3Adesc
,
Sep 5 2017
I piggybacked off the render test infrastructure and took a screenshot during the failing test. Turns out that the Chrome crash dialogue is not being properly dismissed. It's present both before we enter VR https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=b1c45a2f8b05e6258596189f60fee97e32116f77&as=before_vr.png and after https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=5f49a0127a2d9b06aec9cf5079cd1613b82e46bc&as=after_vr.png Looking at the test runner output, it tries to dismiss the error dialog before running the test that ends up failing, but fails to. What's weird is that it recognizes that it didn't dismiss it, but doesn't retry. +CC jbudorick for someone more familiar with Devil/the test runner John - are you aware of any changes to Devil that may have caused this? device_utils.py hasn't been updated in a month, so I'm thinking it's something in the test runner.
,
Sep 5 2017
After some more investigation, it looks like there's actually two possible/simultaneous causes of this. The first is the presence of the crash dialog, which is shown in the above comment. The second is the presence of the immersive move dialog (how this is still showing up is beyond me). In some cases, there is no dialog either before https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=ecc8d01d0bd5dad12d0522a4a346d930821dea01&as=before_vr.png or after https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=c117aae98c25c4489af320f9f316a3037661057a&as=after_vr.png we enter VR. However, when we take a screenshot just before sending the click event, the immersive mode dialog is there https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=b5e2d6b2f90ad43a6dd5d86b3de8c76dab580503&as=before_click.png I'll try running my bot config dump script on the device in question to see if it's properly configured to have anr_show_background disabled.
,
Sep 5 2017
Yep, anr_show_background is disabled on the bot that's still showing the immersive mode dialog https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=fbbb3d633ea109ee0e0bac73f1613be061efa969&as=06aa99ce003b6aae I'm starting to run out of ideas.
,
Sep 6 2017
Brian, assigning this to you as you're working on it. If you hit a dead end, please re-assign or mark Available and clear yourself as the owner. Thanks!
,
Sep 6 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2335c04125758195a77d82cbd8253b17f89ab788 commit 2335c04125758195a77d82cbd8253b17f89ab788 Author: bsheedy <bsheedy@chromium.org> Date: Wed Sep 06 17:06:19 2017 Disable VR screen tap test on K/L Disables WebVrInputTest#testScreenTapsNotRegistered on K and L since it has become flaky on those OSes. Bug: 762126 Change-Id: I24edbcd765583cb824c1ad0692f18033e67d9822 Reviewed-on: https://chromium-review.googlesource.com/651808 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#499994} [modify] https://crrev.com/2335c04125758195a77d82cbd8253b17f89ab788/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
,
Sep 15 2017
One option for debugging this is to record the screen for the duration of the test via something like https://github.com/catapult-project/catapult/commits/master/devil/devil/android/tools/video_recorder.py Watching the resulting clip, you might see where/when/how these dialogue boxes pop up. Other than that, I'm not sure what else you can do here.
,
Sep 15 2017
Issue 765255 has been merged into this issue.
,
Sep 15 2017
It seems our other L testers are also having trouble dismissing the dialogue boxes: https://chromium-swarm.appspot.com/task?id=389f4926abbc3010
,
Sep 15 2017
,
Sep 25 2017
Do you think this could be related to Issue 761806? Different failure types, but both look related to issues closing crash dialogue boxes on L.
,
Mar 6 2018
Issue 818165 has been merged into this issue.
,
Mar 6 2018
Issue 818263 has been merged into this issue.
,
Mar 6 2018
Issue 818217 has been merged into this issue.
,
Jul 4
,
Aug 7
Removing Internals>VR component and remapping to Internals>XR
,
Aug 7
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bsheedy@chromium.org
, Sep 5 2017