New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762123 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Script blackboxing no longer resolves wrapped console.logs

Reported by qro...@gmail.com, Sep 5 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
1. Use a wrapped console log function (in my case, logdown.js) for logging in your application
2. Blackbox the log wrapper via a regex in Devtool Settings>Blackboxing (in my case, '/logdown\.js$')
3. Reload the page with logging
4. Notice that although the logging wrapper file has a 'this script is blackboxed' header in the source inspector, logging is not resolving the non-framework location/line number as described here: https://gist.github.com/paulirish/c307a5a585ddbcc17242
5. Deleting and re-adding the blackboxing regex in Devtools settings will temporarily restore appropriate line numbers, but they will revert to the wrapped logger on page reload.

What is the expected behavior?
https://gist.github.com/paulirish/c307a5a585ddbcc17242

What went wrong?
Sometime between last week and this week, a Chrome update caused this regression

Did this work before? Yes Not sure, but I believe it was working last week

Chrome version: 60.0.3112.113  Channel: n/a
OS Version: OS X 10.12.6
Flash Version: 

For now, deleting and re-adding the blackboxing regex is a viable workaround. If this gets too annoying I'll figure out what version of Chrome broke this feature and update the ticket.
 
Cc: krajshree@chromium.org
Labels: Needs-Triage-M60 Needs-Feedback
qrohlf@ - Thanks for filing the issue...!!

Could you please provide a sample test file to test the issue from TE-end. If possible please provide a screen cast or a screen shot explaining the exact issue.
This will help us in triaging the issue further.

Thanks...!!
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by l...@chromium.org, Oct 30 2017

Cc: kozy@chromium.org
Thanks for the report.  I was unable to reproduce the bug using Linux, version 60.0.3112.0 and 64.0.3254.0. 
 DevTools seemed to use the correct location.  My repro steps are using the URL in the Github gist you linked:
- Go to http://plnkr.co/edit/3wg4u9HUGXfFH0U7MR7j?p=preview
- Add this blackbox pattern in DevTools Settings: /log-helper\.js$
- Reload
- The console message's location still resolves to 'script.js', not the wrapper function's source

A few questions:
- Could you please try this on Chrome Canary?
- Are there other blackboxing patterns that might be interfering?
This isn't working for me in Version 64.0.3256.0 (Official Build) canary (64-bit) on Windows 10, removing the blackbox and reapplying it fixed it 

Comment 5 by l...@chromium.org, Dec 8 2017

Status: Archived (was: Assigned)
Without being able to reproduce the issue, I haven't made any progress on this.  Archiving for now, unless kozy@ has other ideas.

Please feel free to add further comments if you find relevant information.

Sign in to add a comment