New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762121 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Play Store app search result list not cleared when Android crashed or reboot

Project Member Reported by hejq@chromium.org, Sep 5 2017

Issue description

(1) Search for some Play Store apps in the launcher.
(2) See the results in the Play Store.
(3) Android crashes or reboots
(4) Type in the search box and the result list never refreshes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cbb0fed26230ba820c34c42dd6536bd6e5fbe7c

commit 5cbb0fed26230ba820c34c42dd6536bd6e5fbe7c
Author: Jiaquan He <hejq@google.com>
Date: Tue Sep 05 20:15:38 2017

Clear Play Store app search results when Android is down.

Currently Play Store app search results will remain in the launcher
forever if Android crashes or reboots. This commit clears the list
once ArcPlayStoreSearchProvider fails to communicate to Android.

Bug:  762121 
Change-Id: Idd9f889015e4f70a8fb1f8ae96c11076ad86511c
Reviewed-on: https://chromium-review.googlesource.com/651186
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#499726}
[modify] https://crrev.com/5cbb0fed26230ba820c34c42dd6536bd6e5fbe7c/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc

Comment 2 by hejq@chromium.org, Sep 5 2017

Status: Fixed (was: Started)

Comment 3 by hejq@chromium.org, Sep 6 2017

Labels: -M-61 -M-62 Merge-Request-62 Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 -Merge-Request-62 Merge-Approved-61 Merge-Approved-62
Approving merge to M61 and M62.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb994902df13d14f9952d3859131f01f6566b252

commit fb994902df13d14f9952d3859131f01f6566b252
Author: Vadim Tryshev <vadimt@google.com>
Date: Thu Sep 07 21:49:30 2017

Clear Play Store app search results when Android is down.

Currently Play Store app search results will remain in the launcher
forever if Android crashes or reboots. This commit clears the list
once ArcPlayStoreSearchProvider fails to communicate to Android.

TBR=hejq@google.com

(cherry picked from commit 5cbb0fed26230ba820c34c42dd6536bd6e5fbe7c)

Bug:  762121 
Change-Id: Idd9f889015e4f70a8fb1f8ae96c11076ad86511c
Reviewed-on: https://chromium-review.googlesource.com/651186
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#499726}
Reviewed-on: https://chromium-review.googlesource.com/656046
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1135}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/fb994902df13d14f9952d3859131f01f6566b252/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b6dda455f1988598d768783304a75e9e6be434

commit 57b6dda455f1988598d768783304a75e9e6be434
Author: Vadim Tryshev <vadimt@google.com>
Date: Thu Sep 07 21:54:59 2017

Clear Play Store app search results when Android is down.

Currently Play Store app search results will remain in the launcher
forever if Android crashes or reboots. This commit clears the list
once ArcPlayStoreSearchProvider fails to communicate to Android.

TBR=hejq@google.com

(cherry picked from commit 5cbb0fed26230ba820c34c42dd6536bd6e5fbe7c)

Bug:  762121 
Change-Id: Idd9f889015e4f70a8fb1f8ae96c11076ad86511c
Reviewed-on: https://chromium-review.googlesource.com/651186
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#499726}
Reviewed-on: https://chromium-review.googlesource.com/656317
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#70}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/57b6dda455f1988598d768783304a75e9e6be434/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment