New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762112 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[autotest] Zygote code crashes when not run as root

Project Member Reported by kenobi@chromium.org, Sep 5 2017

Issue description

Various bits of code in the Zygote class fail with permissions issues when not run as root.  This problem was previously masked by the fact that unit tests are normally run using sudo.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b0f14169490c1d63d9246d8d7f6ad100be7a1551

commit b0f14169490c1d63d9246d8d7f6ad100be7a1551
Author: Ben Kwa <kenobi@google.com>
Date: Fri Sep 08 04:21:48 2017

[autotest] Fix host-dir permissions.

Change the permissions on the shared host dir and the individual host
dirs so they aren't owned by root, and are writable by regular
processes (e.g. the autoserv process).  This is necessary in order to
enable autoserv to configure the zygotes.

- Set mode 777 on the shared host dir.
- Don't use sudo to create host dirs and install SSPs.
- Don't use sudo (where possible) in unittest code.
- Put a new check in unittests to ensure they're not run as root.
  Running unit tests as root will obscure some of these permissions
  issues.
- Factor unittest setup code so it's all in one place.

BUG= chromium:762112 
TEST=base_image_unittest.py -v
TEST=container_bucket_unittest.py -v
TEST=container_unittest.py -v
TEST=lxc_config_unittest.py -v
TEST=lxc_functional_test.py -v
TEST=shared_host_dir_unittest.py -v
TEST=zygote_unittest.py -v

Change-Id: Idfde131edca57ab563e0bb1923103196728045ec
Reviewed-on: https://chromium-review.googlesource.com/651086
Commit-Ready: Ben Kwa <kenobi@chromium.org>
Tested-by: Ben Kwa <kenobi@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/container.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/lxc_functional_test.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/lxc_config_unittest.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/shared_host_dir.py
[add] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/unittest_setup.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/container_bucket_unittest.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/zygote_unittest.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/container_unittest.py
[delete] https://crrev.com/7002a78182ff25a4fa9c0e4967a98e0c92c58b5f/site_utils/lxc/unittest_logging.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/shared_host_dir_unittest.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/zygote.py
[modify] https://crrev.com/b0f14169490c1d63d9246d8d7f6ad100be7a1551/site_utils/lxc/base_image_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment