cronet_consumer_app_delegate.mm references SDCH |
|||
Issue descriptioncronet_consumer_app_delegate.mm references SDCH in SDCHPrefStoreFileName. Since SDCH is being unshipped in Cronet, can we get rid of this reference?
,
Sep 5 2017
This looks like a dead code, not even used anywhere, so we should remove it.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c71cbedfc9867d9c64f2da228ae91a154c534e99 commit c71cbedfc9867d9c64f2da228ae91a154c534e99 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Fri Sep 08 18:29:39 2017 remove dead sdch code Bug: 762100 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I2640801f83e4d243ca70791645afc8031d73b437 Reviewed-on: https://chromium-review.googlesource.com/658102 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#500627} [modify] https://crrev.com/c71cbedfc9867d9c64f2da228ae91a154c534e99/components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm
,
Sep 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xunji...@chromium.org
, Sep 5 2017