Lock screen note taking animation updates |
|||||||||||||||
Issue descriptionLock screen note taking animation should be updated according to UI review feedback. Instead of fading the app away do the same transition-in animation but in reverse for transition-out.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/322df5de355b3908bafc396cc7ab009b533cba23 commit 322df5de355b3908bafc396cc7ab009b533cba23 Author: Jacob Dufault <jdufault@google.com> Date: Wed Sep 06 00:10:06 2017 cros: Better animation when dismissing lock-screen note. This does not fix the animation if the note app was started via a stylus eject. Bug: 762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie77c765d3b3d65cf0e7be038e384c94b7d5103c5 Reviewed-on: https://chromium-review.googlesource.com/650647 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#499811} [modify] https://crrev.com/322df5de355b3908bafc396cc7ab009b533cba23/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/322df5de355b3908bafc396cc7ab009b533cba23/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/322df5de355b3908bafc396cc7ab009b533cba23/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 6 2017
,
Sep 6 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
Approving merge to M61 and M62.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/501818c9253eaf978d260bb39db575ac2809d231 commit 501818c9253eaf978d260bb39db575ac2809d231 Author: Jacob Dufault <jdufault@google.com> Date: Wed Sep 06 18:46:33 2017 cros: Better animation when dismissing lock-screen note. This does not fix the animation if the note app was started via a stylus eject. TBR=jdufault@google.com (cherry picked from commit 322df5de355b3908bafc396cc7ab009b533cba23) Bug: 762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie77c765d3b3d65cf0e7be038e384c94b7d5103c5 Reviewed-on: https://chromium-review.googlesource.com/650647 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499811} Reviewed-on: https://chromium-review.googlesource.com/653427 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1121} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/501818c9253eaf978d260bb39db575ac2809d231/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/501818c9253eaf978d260bb39db575ac2809d231/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/501818c9253eaf978d260bb39db575ac2809d231/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12642a1f66d2b381a34beeb027937aad6dbeb2c7 commit 12642a1f66d2b381a34beeb027937aad6dbeb2c7 Author: Jacob Dufault <jdufault@google.com> Date: Wed Sep 06 18:52:36 2017 cros: Better animation when dismissing lock-screen note. This does not fix the animation if the note app was started via a stylus eject. TBR=jdufault@google.com (cherry picked from commit 322df5de355b3908bafc396cc7ab009b533cba23) Bug: 762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie77c765d3b3d65cf0e7be038e384c94b7d5103c5 Reviewed-on: https://chromium-review.googlesource.com/650647 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499811} Reviewed-on: https://chromium-review.googlesource.com/653212 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#54} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/12642a1f66d2b381a34beeb027937aad6dbeb2c7/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/12642a1f66d2b381a34beeb027937aad6dbeb2c7/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/12642a1f66d2b381a34beeb027937aad6dbeb2c7/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 6 2017
Passing to tbarzic@ to fix dismiss transition when note-taking app is launched via stylus eject.
,
Sep 6 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40 commit e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40 Author: Toni Barzic <tbarzic@google.com> Date: Tue Sep 12 01:49:56 2017 Update new note action button animation in lock screen UI * Smooth up animation by using scale transform. * Add fade-out animation even in case the note was not launched from the lock screen. * Wait until the fade out animation ends before showing version info. Bug:762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6cb4b733c1e09820644fd6ff406dcf4a66e5ade Reviewed-on: https://chromium-review.googlesource.com/656607 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#501147} [modify] https://crrev.com/e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40/chrome/browser/resources/chromeos/login/md_top_header_bar.html [modify] https://crrev.com/e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 12 2017
Merge request for e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40
,
Sep 12 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
Consider this merge approved for 62, but please ensure a build of Chrome with this change makes it through the PFQ on ToT first, as the branch builders have no PFQ protection. 61 merge can be reviewed after 62 is proven to be ok.
,
Sep 12 2017
Approving merge to M61. Please merge to M62 first.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcf59770d9ee7b983fd285734995a9b1804fd6b7 commit fcf59770d9ee7b983fd285734995a9b1804fd6b7 Author: Toni Barzic <tbarzic@google.com> Date: Fri Sep 15 21:10:59 2017 Update new note action button animation in lock screen UI * Smooth up animation by using scale transform. * Add fade-out animation even in case the note was not launched from the lock screen. * Wait until the fade out animation ends before showing version info. Bug:762097 TBR=tbarzic@google.com (cherry picked from commit e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6cb4b733c1e09820644fd6ff406dcf4a66e5ade Reviewed-on: https://chromium-review.googlesource.com/656607 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501147} Reviewed-on: https://chromium-review.googlesource.com/669097 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#264} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/fcf59770d9ee7b983fd285734995a9b1804fd6b7/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/fcf59770d9ee7b983fd285734995a9b1804fd6b7/chrome/browser/resources/chromeos/login/md_top_header_bar.html [modify] https://crrev.com/fcf59770d9ee7b983fd285734995a9b1804fd6b7/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4bf1d2c3081de3ea17e557afd4cd702a007e5fa commit e4bf1d2c3081de3ea17e557afd4cd702a007e5fa Author: Toni Barzic <tbarzic@google.com> Date: Sat Sep 16 01:43:57 2017 Update new note action button animation in lock screen UI * Smooth up animation by using scale transform. * Add fade-out animation even in case the note was not launched from the lock screen. * Wait until the fade out animation ends before showing version info. Bug:762097 TBR=tbarzic@google.com (cherry picked from commit e5f29c804dbaa96ffa544d5408e4e71bbb3c2b40) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6cb4b733c1e09820644fd6ff406dcf4a66e5ade Reviewed-on: https://chromium-review.googlesource.com/656607 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501147} Reviewed-on: https://chromium-review.googlesource.com/670066 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1216} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/e4bf1d2c3081de3ea17e557afd4cd702a007e5fa/chrome/browser/resources/chromeos/login/md_top_header_bar.css [modify] https://crrev.com/e4bf1d2c3081de3ea17e557afd4cd702a007e5fa/chrome/browser/resources/chromeos/login/md_top_header_bar.html [modify] https://crrev.com/e4bf1d2c3081de3ea17e557afd4cd702a007e5fa/chrome/browser/resources/chromeos/login/md_top_header_bar.js
,
Sep 16 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by jdufault@chromium.org
, Sep 5 2017