New issue
Advanced search Search tips

Issue 762081 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 751901
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:7091


Sign in to add a comment

It's hard to upload CLs dependent on a different developer's CL

Project Member Reported by jamescook@chromium.org, Aug 24 2017

Issue description

I don't know if this is a gerrit issue or a "git cl" issue, but it's hard to figure out how to develop a patch on top of someone else's patch.

I'm working on this patch:
https://chromium-review.googlesource.com/c/chromium/src/+/634329

It requires the changes in sammc's patch:
https://chromium-review.googlesource.com/c/chromium/src/+/624772

I used "git cl patch" to make a local branch with his code. The first time I did this it warns me:

Note: this created a local commit which does not have the same hash as the one uploaded for review. This will make uploading changes based on top of this branch difficult.
If you want to do that, use "git cl patch --force" instead.

So then I patched with --force and made a new local branch on top.

But when I tried to "git cl upload" my new branch I get:

Upload upstream branch sam2 first.
It is likely that this branch has been rebased since its last upload, so you just need to upload it again.
(If you uploaded it with --no-squash, then branch dependencies are not supported, and you should reupload with --squash.)

I ended up patching in sam's change, resetting its issue number, uploading that branch as if I wrote it, then uploading my real change on top of that.

It seems like there should be a better workflow for this, or better suggestions from the tools.

 

Comment 1 by logan@google.com, Sep 5 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration

Comment 2 by logan@google.com, Sep 5 2017

Project: chromium
Moved issue gerrit:7091 to now be  issue chromium:762081 .
Components: Infra>Codereview>Gerrit
Labels: -Proj-Gerrit-Migration
Mergedinto: 751901
Status: Duplicate (was: New)
Known issue. This is truly a hard problem. We've got our best minds on it.

Sign in to add a comment