New issue
Advanced search Search tips

Issue 762078 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 762405
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

DownloadItemControllerTest intermittent failures

Project Member Reported by shrike@chromium.org, Sep 5 2017

Issue description

There are intermittent test failures on the 10.10 bot - for example, https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/23253

The backtrace is confusing me a bit, but I believe the problem is the -remove: call being made within TEST_F(DownloadItemControllerTest, RemovesSelfWhenDownloadIsDestroyed). Apparently the mock DownloadShelfController doesn't know about it (I'm not sure how it knows which methods are valid).

sdy@, can you take a peek?

[ RUN      ] DownloadItemControllerTest.NormalDownload
2017-09-05 06:06:08.697 unit_tests[63763:989746] An uncaught exception was raised
2017-09-05 06:06:08.697 unit_tests[63763:989746] OCMockObject(DownloadShelfController): unexpected method invoked: remove:<DownloadItemController: 0x7fc534430f40>
2017-09-05 06:06:08.697 unit_tests[63763:989746] (
	0   CoreFoundation                      0x00007fff8ba9203c __exceptionPreprocess + 172
	1   unit_tests                          0x000000010795fa5b _ZN6chromeL25ObjcExceptionPreprocessorEP11objc_object + 1019
	2   libobjc.A.dylib                     0x00007fff9403776e objc_exception_throw + 43
	3   CoreFoundation                      0x00007fff8ba91eed +[NSException raise:format:] + 205
	4   unit_tests                          0x000000010559c103 -[OCMockObject handleUnRecordedInvocation:] + 147
	5   unit_tests                          0x000000010559bbe1 -[OCMockObject forwardInvocation:] + 49
	6   CoreFoundation                      0x00007fff8b9dac26 ___forwarding___ + 518
	7   CoreFoundation                      0x00007fff8b9da998 _CF_forwarding_prep_0 + 120
	8   unit_tests                          0x0000000106d550c1 _ZN7content16MockDownloadItemD2Ev + 193
	9   unit_tests                          0x0000000103b6cc80 _ZN7testing8NiceMockIN7content16MockDownloadItemEED0Ev + 32
	10  unit_tests                          0x00000001052740f6 _ZN12_GLOBAL__N_126DownloadItemControllerTest8TearDownEv + 38
	11  unit_tests                          0x00000001055b5330 _ZN7testing8TestInfo3RunEv + 288
	12  unit_tests                          0x00000001055b5897 _ZN7testing8TestCase3RunEv + 263
	13  unit_tests                          0x00000001055bbac7 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 871
	14  unit_tests                          0x00000001055bb733 _ZN7testing8UnitTest3RunEv + 163
	15  unit_tests                          0x0000000106c4dab3 _ZN4base9TestSuite3RunEv + 163
	16  unit_tests                          0x0000000106c5a8eb _ZN4base15LaunchUnitTestsEiPPcRKNS_17RepeatingCallbackIFivEEE + 139
	17  unit_tests                          0x0000000106c43504 main + 276
	18  libdyld.dylib                       0x00007fff8df545c9 start + 1
	19  ???                                 0x0000000000000008 0x0 + 8
)

 

Comment 1 by sdy@chromium.org, Sep 7 2017

Mergedinto: 762405
Status: Duplicate (was: Untriaged)

Sign in to add a comment