I think that we should just get rid of tools/symsrc entirely, the source indexing is now done via another script (in chrome/tools/symsrc/ in the internal repo) and most of this directory's content is old files that haven't been updated for a while.

Last time I've checked we still wanted to keep these files here mostly for documentation purposes (i.e. this is how we do source indexing in Chrome), but I don't think that this is a valid argument (having these files confuses a lot of people and this copy is really outdated, it only supports SVN). We (apparently) also don't want to use them on the official bot for security reasons, hence the internal version.

I'm not sure why these files get checked out on buildbots, but imho removing them and using only third_party/pefile  is the right thing to do.

tools/symsrc is definitely used to prepare .pd_ files for clang binaries that we upload to the symbol server.

Ha, are you source-indexing these binaries? 

At the moment only symbol-indexing, here https://cs.chromium.org/chromium/src/tools/clang/scripts/package.py?q=package.py&sq=package:chromium&dr&l=131

That was added for  bug 682500 .

bug 700381 is about adding a source index too.

Ha ok, what bothers me is that tools/symsrc/source_index.py is outdated* and should probably be removed to reduce the confusion. If we do this then tools/symsrc should probably be renamed tools/pe_utils as it's what it is. 


* The main difference is that this version supports SVN only, while the internal one is for Git only.