Effective connection type with value UNKNOWN should not be persisted |
|||||||
Issue descriptionOn connection change events, NQE (Network Quality Estimator) may briefly set the value of the effective connection type (ECT) as UNKNOWN. This value may be reported to network quality store, and it may be persisted in the prefs, where it may overwrite a known value of ECT. NQE should not persist ECTs with value UNKNOWN to prevent overwriting of ECT values (e.g., slow2g, 2g, 3g, 4g) which may be more precise and useful.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7718847e9938b80e58148d91555c2bb6eff9b14 commit d7718847e9938b80e58148d91555c2bb6eff9b14 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Sep 08 01:31:29 2017 Do not store ECT if it's value is unknown Do not store Effective Connection Type (ECT) in prefs if its value is UNKNOWN. Also, enable caching for Ethernet connections in Network Quality Estimator (NQE). Bug: 762064 Change-Id: I19b7f51644bdf9b6ccfa7182500b3cba27febd52 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/648651 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#500474} [modify] https://crrev.com/d7718847e9938b80e58148d91555c2bb6eff9b14/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/d7718847e9938b80e58148d91555c2bb6eff9b14/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/d7718847e9938b80e58148d91555c2bb6eff9b14/net/nqe/network_quality_store.cc [modify] https://crrev.com/d7718847e9938b80e58148d91555c2bb6eff9b14/net/nqe/network_quality_store_unittest.cc
,
Sep 8 2017
,
Sep 8 2017
Can you please mark all impacted OS's in the bug?
,
Sep 8 2017
,
Sep 8 2017
,
Sep 8 2017
Approving merge for M62. Branch:3202
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab57abe7919e588077d9c8471b48ec2bac05c06b commit ab57abe7919e588077d9c8471b48ec2bac05c06b Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Sep 08 23:17:36 2017 Do not store ECT if it's value is unknown Do not store Effective Connection Type (ECT) in prefs if its value is UNKNOWN. Also, enable caching for Ethernet connections in Network Quality Estimator (NQE). Bug: 762064 Change-Id: I19b7f51644bdf9b6ccfa7182500b3cba27febd52 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/648651 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500474}(cherry picked from commit d7718847e9938b80e58148d91555c2bb6eff9b14) Reviewed-on: https://chromium-review.googlesource.com/658333 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#102} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ab57abe7919e588077d9c8471b48ec2bac05c06b/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/ab57abe7919e588077d9c8471b48ec2bac05c06b/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/ab57abe7919e588077d9c8471b48ec2bac05c06b/net/nqe/network_quality_store.cc [modify] https://crrev.com/ab57abe7919e588077d9c8471b48ec2bac05c06b/net/nqe/network_quality_store_unittest.cc
,
Sep 8 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbansal@chromium.org
, Sep 5 2017