New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762054 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-01-08
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707649
issue 672921



Sign in to add a comment

Upstream overscroll-behavior layout-test to web-platform-tests

Project Member Reported by sunyunjia@chromium.org, Sep 5 2017

Issue description

Currently we have a scroll-boundary-behavior.html as a layout-test. To get ready for shipping this feature, we need to upstream the layout-test to web-platform-test.

 
Summary: Upstream scroll-boundary-behavior layout-test to web-platform-tests (was: Upstream scroll-boundary-behavior layout-test to web-plat-form-test)
Blocking: 707649
Cc: kereliuk@chromium.org
Can you elaborate on what kind of automation will be needed in web-platform-tests to support this?

https://github.com/w3c/web-platform-tests/pull/6897 is adding the infrastructure for some (initially) basic forms of input automation, which could be extended. Will some existing WebDriver API do the job, or do you need something new?
We were thinking about using similar technique as is used by pointer-events tests [1,2]. Those tests are manual tests but they get an automation script injected into them that automates them for Chromium using chrome.gpuBenchmarking API.


Currently our test depends on chrome.gpuBenchmarking.smoothScrollBy to induce a
scroll. So at the very lease we need something like that. But I imagine it can be made to work with pointer{down, move, up} as well to simulate scroll. Is this true sunyunjia@? 


The link for wpt automation seems to be only adding 'click' which is not
enough. It seems our best bet if to do what we originaly planned and then
once WPT has more matching automation then consider changing the tests to
use them and thus be automated across all browsers.


[1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-manual.html
[2] https://codesearch.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-manual-automation.js?q=pointerevent_pointermove_on_chorded_mouse_button&sq=package:chromium&dr
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/682b325c0a627994bc559ee8a88dd5bfc8e0c1c8

commit 682b325c0a627994bc559ee8a88dd5bfc8e0c1c8
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Wed Sep 13 15:14:02 2017

Upstream scroll-boundary-behavior.html to wpt test.

This patch upstreams scroll_boundary_behavior.html to a web-platfrom-test. It
is currently a manual test. It asks users to perform some scroll/drag
behaviors and tap the "Done" button, and then checks the result.

Bug:  762054 
Change-Id: I9be937341d5d95137c715b8111b557f09baf8a80
Reviewed-on: https://chromium-review.googlesource.com/653810
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501633}
[modify] https://crrev.com/682b325c0a627994bc559ee8a88dd5bfc8e0c1c8/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/682b325c0a627994bc559ee8a88dd5bfc8e0c1c8/third_party/WebKit/LayoutTests/external/wpt/cssom-view/scrollBoundaryBehavior-manual.html

majid@

This functionality is currently being added to ChromeDriver and soon the GPUBenchmarking dependency shouldn't be needed after that. I expect to be finished by the end of the month.
NextAction: 2017-11-15
Summary: Upstream overscroll-behavior layout-test to web-platform-tests (was: Upstream scroll-boundary-behavior layout-test to web-platform-tests)
sunyunjia@: based on #6, we should check now to see if chromedriver supports what we need to automate this test.
The NextAction date has arrived: 2017-11-15
NextAction: 2018-01-08
Labels: -Pri-2 Pri-3
The NextAction date has arrived: 2018-01-08
Blocking: 672921
Status: Fixed (was: Started)

Sign in to add a comment