New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762033 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Divider on Content Notifications Settings page is too wide

Project Member Reported by peconn@chromium.org, Sep 5 2017

Issue description

The divider between the two items on the Content Notifications Settings page is too wide. This was picked up during UI review.
 
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e90c2824dc6946559191d0d2089be41a0ea5f5

commit e8e90c2824dc6946559191d0d2089be41a0ea5f5
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Sep 05 15:22:05 2017

🏡 Remove divider from Notifications Preferences page.

Bug:  762033 
Change-Id: I1f9bb01d495ff7b437fbc1e44c53172dffe997a4
Reviewed-on: https://chromium-review.googlesource.com/649531
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499639}
[modify] https://crrev.com/e8e90c2824dc6946559191d0d2089be41a0ea5f5/chrome/android/java/res/xml/notifications_preferences.xml
[modify] https://crrev.com/e8e90c2824dc6946559191d0d2089be41a0ea5f5/chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java

Labels: Merge-Request-62
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827b654890a5b005c99725ccd89a19c446b7349b

commit 827b654890a5b005c99725ccd89a19c446b7349b
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Sep 07 09:05:14 2017

🏡 Remove divider from Notifications Preferences page.

TBR=peconn@chromium.org

(cherry picked from commit e8e90c2824dc6946559191d0d2089be41a0ea5f5)

Bug:  762033 
Change-Id: I1f9bb01d495ff7b437fbc1e44c53172dffe997a4
Reviewed-on: https://chromium-review.googlesource.com/649531
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499639}
Reviewed-on: https://chromium-review.googlesource.com/654661
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#62}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/827b654890a5b005c99725ccd89a19c446b7349b/chrome/android/java/res/xml/notifications_preferences.xml
[modify] https://crrev.com/827b654890a5b005c99725ccd89a19c446b7349b/chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java

Comment 6 by peconn@chromium.org, Sep 11 2017

Status: Fixed (was: Started)
To verify this issue, could you please share expected UI, after this change

Sign in to add a comment