New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762028 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

topSites is broken displays single time visited sites

Reported by labobol...@gmail.com, Sep 5 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
Unknown. Happens often after chrome crash due to hitting memory roof. Also just after having closed a tab.

What is the expected behavior?
Show most visited sites list.

What went wrong?
1. Shows single visit sites.
2. Doesn't update correctly. When a list is collected, it's nearly set in stone.

Did this work before? Yes Unknown

Chrome version: 60.0.3112.113  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

topSites needs a diagnostic debug panel to figure out why this happens.

Only solution is to use an extension that completely avoids topsites API including trusting the history database. For example 'Fauxbar' that use Firefox's way (frecency) that's far superior. Fauxbar seem to do a good job even with Chrome's extreme API limitations and bugs connected to the history and link clicks.
 
Cc: sc00335...@techmahindra.com
Components: -UI UI>Browser>NewTabPage
Labels: Triaged-ET Needs-Triage-M60 Needs-Feedback
Tested the issue on 60.0.3112.113 using Windows 7 with steps mentioned below and is not reproducible

Visited amazon.com, naver.com multiple times ,closed those tabs and observed thumbnails of most visited sites in NTP.

@Reporter:Could you please re-check the same on fresh profile and provide screenshot for reference.

Comment 2 by treib@chromium.org, Sep 6 2017

Components: UI>Browser>History
It's not quite clear to me what the bug is here. It's fine for TopSites to show a site you've only visited once, if you haven't visited anything else recently. OTOH, in a profile with a lot of history, it's expected that the list is quite stable.
Could you provide some more detail on what exactly is happening, and what you would expect to see instead?

Some background: TopSites in fact also uses a "frecency" algorithm. It's typically updated when you open a new tab, and also periodically in the background.
@1: Tried it and still unable to figure out what cause it.

@2: I'm visiting all eight sites nearly every day which is why it's weird.

TopSites uses a similar algorithm to frecency, I was told. Think a dev called it 'recency'.

Anyway, wrong or not I've used Firefox a lot and written a frecency algorithm in javascript in an extension for Chrome (as much as a could with the limited and buggy api). Frecency algorithm in my experience just don't behave like what I've observed. Although I did use the values ("algorithm settings") that Firefox use. Perhaps chrome uses different values yet it still behaves weirdly.

I'd like to check the underlying database values to see what's happening. Hence the request for a diagnostic debug panel of sorts. I have checked the TopSites sql file however I only saw the results and not the raw data it use.

Perhaps a history diagnostic panel that have a topsites tab since history needs one too?

Can the history data be corrupt in some way? Is there a way to check if it is?
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I made a search on google and Chrome crashed. As expected when starting it up again the bug showed its ugly head, this time. Perhaps this screenshot helps.
topsites__db_sql_screenshot_send.png
108 KB View Download

Comment 6 by treib@chromium.org, Sep 8 2017

Hm, the highlighted row has rank 10, so it shouldn't actually show up on the NTP. Though if it was only visited once, it's still weird that it is so high.

If you're interested, the actual TopSites algorithm is implemented in VisitSegmentDatabase::QuerySegmentUsage, here: https://cs.chromium.org/chromium/src/components/history/core/browser/visitsegment_database.cc?type=cs&sq=package:chromium&l=205

Comment 7 by fi...@chromium.org, Sep 18 2017

Labels: -Pri-2 Pri-3

Comment 8 by fi...@chromium.org, Sep 18 2017

Labels: zine-triaged
Labels: Needs-Feedback
@Reporter: Are you still seeing this issue on latest channels, please check the above comment and respond the comment with latest behavior. You can download latest build from https://www.chromium.org/getting-involved/dev-channel.
Status: WontFix (was: Unconfirmed)
Due to lack of user feedback closing this issue.
Please feel free to raise a new one if you face any chrome issue further.
Thanks..!
I think that item is showing up because the domain is google.se. Most of them, if not all of them, are google searches. Perhaps this single visit is showing up because google.se is often visited to search for things?

Sign in to add a comment