New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/html/semantics/embedded-content/media-elements/video_loop_base.html crashes on a DCHECK

Project Member Reported by raphael....@intel.com, Sep 5 2017

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/650248 removed several web-platform-tests files from the list of tests we skip.

https://chromium-review.googlesource.com/c/chromium/src/+/650028 is the first CL to automatically import them into Blink. One of the tests, external/wpt/html/semantics/embedded-content/media-elements/video_loop_base.html, crashes on a DCHECK and prevent further imports.

From https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/539544/layout-test-results/results.html:

[24795:24795:0905/064145.778012:12255109751:FATAL:video_decode_stats_recorder.cc(28)] Check failed: profile != VIDEO_CODEC_PROFILE_UNKNOWN (-1 vs. -1)
#0 0x000001bd73d7 base::debug::StackTrace::StackTrace()
#1 0x000001bee2d1 logging::LogMessage::~LogMessage()
#2 0x000002e81bfe media::VideoDecodeStatsRecorder::StartNewRecord()
#3 0x000000893c6e media::mojom::VideoDecodeStatsRecorderStubDispatch::Accept()
#4 0x000001db502f mojo::InterfaceEndpointClient::HandleValidatedMessage()
#5 0x000001dc90c6 mojo::FilterChain::Accept()
#6 0x000001db62dc mojo::InterfaceEndpointClient::HandleIncomingMessage()
#7 0x000001dbe468 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#8 0x000001dbd9f7 mojo::internal::MultiplexRouter::Accept()
#9 0x000001dc90c6 mojo::FilterChain::Accept()
#10 0x000001db3f81 mojo::Connector::ReadSingleMessage()
#11 0x000001db49a2 mojo::Connector::ReadAllAvailableMessages()
#12 0x000001db481c mojo::Connector::OnHandleReadyInternal()
#13 0x000000949270 mojo::SimpleWatcher::DiscardReadyState()
#14 0x000001dcbbb2 mojo::SimpleWatcher::OnHandleReady()
#15 0x000001dcc078 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#16 0x000001bd7b39 base::debug::TaskAnnotator::RunTask()
#17 0x000001c7ced2 base::internal::IncomingTaskQueue::RunTask()
#18 0x000001bf4b36 base::MessageLoop::RunTask()
#19 0x000001bf518f base::MessageLoop::DoWork()
#20 0x000001bf722a base::(anonymous namespace)::WorkSourceDispatch()
#21 0x7f6f1200ae04 g_main_context_dispatch
#22 0x7f6f1200b048 <unknown>
#23 0x7f6f1200b0ec g_main_context_iteration
#24 0x000001bf7006 base::MessagePumpGlib::Run()
#25 0x000001bf45da base::MessageLoop::Run()
#26 0x000001c15a57 base::RunLoop::Run()
#27 0x0000014dee9c content::BrowserMainLoop::MainMessageLoopRun()
#28 0x0000014dec2e content::BrowserMainLoop::RunMainMessageLoopParts()
#29 0x0000014e1ceb content::BrowserMainRunnerImpl::Run()
#30 0x000001b84f25 LayoutTestBrowserMain()
#31 0x000001b84800 content::ShellMainDelegate::RunProcess()
#32 0x0000013fe4a6 content::RunNamedProcessTypeMain()
#33 0x0000013ff020 content::ContentMainRunnerImpl::Run()
#34 0x000002f29360 service_manager::Main()
#35 0x0000009fa8d2 content::ContentMain()
#36 0x00000041d2c4 main
#37 0x7f6f0df38f45 __libc_start_main
#38 0x00000041d1a0 <unknown>

This crashes on Mac and Linux, and I think it'll fail on Windows as well (the tests are still running there).

For now, I'm going to mark this test as crashing so further WPT imports can continue.
 

Comment 1 by f...@opera.com, Sep 5 2017

> For now, I'm going to mark this test as crashing so further WPT imports can continue.

Thanks, SGTM. Maybe the test runner ends up using the .ogg version of the video resource.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fc2680b3f5a55910c378b4534d349381e1b1be4

commit 8fc2680b3f5a55910c378b4534d349381e1b1be4
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Tue Sep 05 14:15:51 2017

Mark upcoming wpt test as both passing and crashing.

external/wpt/html/semantics/embedded-content/media-elements/video_loop_base.html
crashes when DCHECKs are enabled. Mark it as both passing and crashing so
that new WPT imports are not blocked on the crash.

NOTRY=true
TBR=qyearsley@chromium.org,foolip@chromium.org

Bug:  762017 
Change-Id: I2cadf63b59ce57d916285c9c11fa174fd19221fb
Reviewed-on: https://chromium-review.googlesource.com/649518
Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#499622}
[modify] https://crrev.com/8fc2680b3f5a55910c378b4534d349381e1b1be4/third_party/WebKit/LayoutTests/TestExpectations

Thanks Raphael! FYI, the general bug here is bug 674692.
I considered using that bug number here, but I figured filing a separate bug about this issue would make it easier for the right teams to notice it and fix it. Should we default to just using bug 674692 as a rule of thumb?
I think filing a separate bug is good, I was linking to that bug just for reference :-)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18d73b4eee22b7a5dda4714d6f4a62a4d987d70

commit f18d73b4eee22b7a5dda4714d6f4a62a4d987d70
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Fri Sep 07 13:51:56 2018

Tentatively stop considering video_loop_base.html is crashing

The test was originally crashing with DCHECKs enabled, but it no longer
seems to do that according to the flakiness dashboard.

TBR=foolip

Bug:  762017 
Change-Id: I1a67b94ff5fef93906ae471d49341d59d51fcb78
Reviewed-on: https://chromium-review.googlesource.com/1213165
Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#589506}
[modify] https://crrev.com/f18d73b4eee22b7a5dda4714d6f4a62a4d987d70/third_party/WebKit/LayoutTests/TestExpectations

Owner: raphael....@intel.com
Status: Fixed (was: Untriaged)
Thanks, Philip. Let's see if the change above sticks.

Sign in to add a comment