Issue metadata
Sign in to add a comment
|
CL don't get landed if I don't explicitly click "Start Review" |
||||||||||||||||||||||
Issue descriptionYesterday I wrote a CL [1] that was quite important as a DCHECK at startup was hurting developers. I got a review, CQ was green. I pressed "Submit to CQ" and went home. This morning I found that the CL didn't land because: --- Failed to submit 1 change due to the following problems: Change 574854: Change 574854 is work in progress --- I have to admit I didn't even get immediately what that was trying to tell me. A colleague had to explain me that I had to click the "start review" button explicitly. Now the problem is: I definitely clicked on the "Submit to CQ" button. That definitely means that I intend to land that CL. I don't feel I need this sort of redundant safety where I have to "unlock" the cl first. This was not an issue with Rietveld, ticking "commit" was just committing for realz. [1] https://chromium-review.googlesource.com/c/574854/#message-e73cdf2f25428c48e3e3543cbf8edcce8206ad5e
,
Sep 5 2017
,
Sep 5 2017
,
Sep 11 2017
git-cl fix: https://chromium-review.googlesource.com/661317
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/edbc41320d62d96df2287200488f02729b4de963 commit edbc41320d62d96df2287200488f02729b4de963 Author: Aaron Gable <agable@chromium.org> Date: Mon Sep 11 22:04:09 2017 git-cl upload: Send mail when starting CQ R=tandrii@chromium.org Bug: 762009 Change-Id: I29a4ca06e0d29f5acb6c516d413fa2a35f8a5629 Reviewed-on: https://chromium-review.googlesource.com/661317 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/edbc41320d62d96df2287200488f02729b4de963/git_cl.py
,
Sep 11 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aelias@chromium.org
, Jul 26 2017Labels: -Priority-3 Priority-2