New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6767


Sign in to add a comment

CL don't get landed if I don't explicitly click "Start Review"

Project Member Reported by primiano@chromium.org, Jul 18 2017

Issue description

Yesterday I wrote a CL [1] that was quite important as a DCHECK at startup was hurting developers. I got a review, CQ was green. I pressed "Submit to CQ" and went home.
This morning I found that the CL didn't land because:

---
Failed to submit 1 change due to the following problems:
Change 574854: Change 574854 is work in progress
---

I have to admit I didn't even get immediately what that was trying to tell me. A colleague had to explain me that I had to click the "start review" button explicitly.

Now the problem is: I definitely clicked on the "Submit to CQ" button. That definitely means that I intend to land that CL. I don't feel I need this sort of redundant safety where I have to "unlock" the cl first.
This was not an issue with Rietveld, ticking "commit" was just committing for realz.

[1] https://chromium-review.googlesource.com/c/574854/#message-e73cdf2f25428c48e3e3543cbf8edcce8206ad5e
 

Comment 1 by aelias@chromium.org, Jul 26 2017

Cc: aelias@chromium.org
Labels: -Priority-3 Priority-2
In particular, this means "-c" command-line upload flag is entirely broken.  An example is https://chromium-review.googlesource.com/c/588080/ .  I uploaded it with TBR, NOTRY and "git cl upload -c".  CQ failed in https://chromium-review.googlesource.com/c/588080/#message-c7455e7c5679c81177ab2c2d064e8e172f4ee362 with "Change 588080 is work in progress"

Comment 2 by logan@google.com, Sep 5 2017

Labels: -Type-Bug -Priority-2 Proj-Gerrit-Migration

Comment 3 by logan@google.com, Sep 5 2017

Project: chromium
Moved issue gerrit:6767 to now be  issue chromium:762009 .

Comment 4 by aga...@chromium.org, Sep 11 2017

Components: Infra>SDK
Labels: Milestone-Afterglow
Owner: aga...@chromium.org
Status: Started (was: New)
git-cl fix: https://chromium-review.googlesource.com/661317
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/edbc41320d62d96df2287200488f02729b4de963

commit edbc41320d62d96df2287200488f02729b4de963
Author: Aaron Gable <agable@chromium.org>
Date: Mon Sep 11 22:04:09 2017

git-cl upload: Send mail when starting CQ

R=tandrii@chromium.org

Bug:  762009 
Change-Id: I29a4ca06e0d29f5acb6c516d413fa2a35f8a5629
Reviewed-on: https://chromium-review.googlesource.com/661317
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/edbc41320d62d96df2287200488f02729b4de963/git_cl.py

Comment 6 by aga...@chromium.org, Sep 11 2017

Status: Fixed (was: Started)

Sign in to add a comment